Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/a corner case of remote workspace detection #1183

Merged
merged 1 commit into from
Feb 19, 2025
+4 −1
Merged

Fix/a corner case of remote workspace detection #1183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion testplan/common/remote/remote_resource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,10 @@ def _create_remote_dirs(self) -> None:
label="remove remote plan runpath",
)

# NOTE: corner case: runpath under workspace
# NOTE: should check existence before any mkdir call
exist_on_remote = self._check_workspace()

self._execute_cmd_remote(
cmd=mkdir_cmd(self._remote_plan_runpath),
label="create remote plan runpath",
Expand All @@ -290,7 +294,6 @@ def _create_remote_dirs(self) -> None:
# TODO: testplan_lib will resolved to site-packages under venv,
# TODO: while rpyc_classic.py under bin isn't included

exist_on_remote = self._check_workspace()
self._prepare_workspace(exist_on_remote)

# NOTE: if workspace under testplan_lib (testplan installed in
Expand Down
Loading