Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove tx count validation #147

Merged
merged 3 commits into from
Oct 14, 2024
Merged

remove tx count validation #147

merged 3 commits into from
Oct 14, 2024

Conversation

FletcherMan
Copy link
Collaborator

1. Purpose or design rationale of this PR

remove tx count check when validating the block

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@FletcherMan FletcherMan requested a review from a team as a code owner October 9, 2024 12:16
@FletcherMan FletcherMan merged commit d702fab into main Oct 14, 2024
@FletcherMan FletcherMan deleted the remove_tx_count_validate branch October 14, 2024 09:11
github-actions bot pushed a commit that referenced this pull request Oct 14, 2024
* remove tx count validation

---------

Co-authored-by: fletcher.fan <[email protected]>
FletcherMan added a commit that referenced this pull request Oct 14, 2024
remove tx count validation (#147)

* remove tx count validation

---------

Co-authored-by: FletcherMan <[email protected]>
Co-authored-by: fletcher.fan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants