Feature/ws3 adapter #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzaar
reviewed
Dec 22, 2017
| @@ -13,13 +13,14 @@ | |||
| <AppDesignerFolder>Properties</AppDesignerFolder> | |||
| <RootNamespace>AspNetSamples</RootNamespace> | |||
| <AssemblyName>AspNetSamples</AssemblyName> | |||
| <TargetFrameworkVersion>v4.0</TargetFrameworkVersion> | |||
| <TargetFrameworkVersion>v4.5</TargetFrameworkVersion> | |||
There was a problem hiding this comment.
Why are we bumping .Net version to 4.5? Libraries are better off targeting a lower version for maximum reach.
There was a problem hiding this comment.
What about VS 7.0 and .NET 1.0? .Net 4.5 was released almost 6 years ago. Sometimes I can't install packages from nuget into .4.5 project, because no one want to target 6 years old framework. And you still care about people who use almost 8 years old framework. As far as i remember ws3.client targets .net 4.0 but not a client profile version.
| <Reference Include="System.Web.DynamicData" /> | ||
| <Reference Include="System.Web.Entity" /> | ||
| <Reference Include="System.Web.Extensions" /> | ||
| <Reference Include="System.Xml.Linq" /> |
|
Не очень понятно, почему "+672 −2,927". Вроде бы должно быть примерно поровну + и -. Сейчас попробую сделать новый бранч. |
bzaar
added a commit
that referenced
this pull request
Dec 22, 2017
|
@bzaar Не очень понятно, почему "+672 −2,927". - Авто сгенерированный код для SOAP клиент. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.