Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an interface for the main contract #8

Closed
QGarchery opened this issue Sep 10, 2024 · 1 comment
Closed

Create an interface for the main contract #8

QGarchery opened this issue Sep 10, 2024 · 1 comment

Comments

@QGarchery
Copy link
Contributor

A nice feature would be to have an interface for this liquidation protection contract. If the mapping subscriptions is public, then we should use the methodology of morpho-blue where we can fetch structs directly. So this would mean that instead of doing
Screenshot from 2024-09-03 12-16-13
we could simply do assertEq(params, liquidationProtection(subscriptions(subscriptionId)));
(this example is taken from #3)
I can do the PR on top of #3 if we want to go for it

Originally posted by @QGarchery in #1 (comment)

@QGarchery
Copy link
Contributor Author

Completed in abce0a0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant