Fixed LI-CF PreLiquidation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QGarchery
reviewed
Sep 3, 2024
QGarchery
reviewed
Sep 3, 2024
QGarchery
reviewed
Sep 3, 2024
QGarchery
reviewed
Sep 3, 2024
QGarchery
reviewed
Sep 3, 2024
MathisGD
reviewed
Sep 24, 2024
QGarchery
previously approved these changes
Sep 25, 2024
MathisGD
reviewed
Sep 25, 2024
QGarchery
previously approved these changes
Sep 25, 2024
colin-morpho
previously approved these changes
Sep 25, 2024
QGarchery
approved these changes
Sep 25, 2024
colin-morpho
approved these changes
Sep 25, 2024
|
Should we delete branches after they've been merged? |
Yes because then on github the PRs on top have their base branch changed automatically, which prevents some mistakes when merging multiple PRs. So for example #19 base branch is now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for the Morpho Liquidation Protection Contract
The general idea is that this contract will allow borrowers to be pre-liquidated on some Morpho market for specific pre-liquidation parameters.
A factory can deploy pre-liquidation contracts each implementing pre-liquidation for its own specific parameters and its own specific morpho market.
A borrower can then authorize the pre-liquidation contract on morpho which will allow liquidators to close part of the position when it is insolvent under the pre-liquidation parameters