Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc/clarification #93

Merged
merged 6 commits into from
Feb 19, 2025
Merged

Doc/clarification #93

merged 6 commits into from
Feb 19, 2025

Conversation

peyha
Copy link
Collaborator

@peyha peyha commented Feb 18, 2025

No description provided.

README.md Outdated
Comment on lines 48 to 49
Note: using `preLCF2 > 1`, one can select at which LTV between preLltv and LLTV the entire position can be pre-liquidated.
A pre-liquidation close factor higher than 100% means that the whole position is pre-liquidatable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Note: using `preLCF2 > 1`, one can select at which LTV between preLltv and LLTV the entire position can be pre-liquidated.
A pre-liquidation close factor higher than 100% means that the whole position is pre-liquidatable.
Note: A pre-liquidation close factor higher than 100% means that the whole position is pre-liquidatable, so using `preLCF2 > 1` allows to make the position entirely pre-liquidatable at a LTV between preLltv and LLTV.

README.md Outdated
Note: using `preLCF2 > 1`, one can select at which LTV between preLltv and LLTV the entire position can be pre-liquidated.
A pre-liquidation close factor higher than 100% means that the whole position is pre-liquidatable.

The last property ensures that pre-liquidation cannot seize more than the total collateral of the position.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The last property ensures that pre-liquidation cannot seize more than the total collateral of the position.

misleading imo, this is enforced by Morpho Blue anyway. Plus the close factor is on the debt, not the collat

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wanted to justify the property preLIF2 <= 1 / LLTV because it's not completely obvious
agree that it's misleading because morpho blue enforce it, i'll try to find a better phrasing otherwise we can drop it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh and also I thought that you where speaking about the last sentence (and not bullet point)

then ok i understand what you mean. We can say to "prevent decreasing the position's health" (that's the precise reason right?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just rephrased, yes it's to make sure that preliquidation always improve the health of the position (just noticed that it also ensures that pre-liquidation seize less than the total collateral)

MathisGD
MathisGD previously approved these changes Feb 19, 2025
README.md Outdated

Note: A pre-liquidation close factor higher than 100% means that the whole position is pre-liquidatable, so using `preLCF2 > 1` allows to make the position entirely pre-liquidatable at a LTV between preLltv and LLTV.

The property `preLIF2 <= 1 / LLTV` ensures that pre-liquidation always improves the health of the position.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the only assumption that is needed: health doesn't get worse iff preLIF <= 1 / LTV
This is ensured because pre-liquidations are only allowed for LTV <= LLTV, which implies that 1 / LLTV <= 1 / LTV. So together with the property preLIF2 <= 1 / LLTV (and preLIF <= preLIF2) we get preLIF <= 1 / LTV

Suggested change
The property `preLIF2 <= 1 / LLTV` ensures that pre-liquidation always improves the health of the position.
The property `preLIF2 <= 1 / LLTV` and the fact that pre-liquidations are only allowed for `LTV <= LLTV` ensure that pre-liquidations can't worsen the health of the position.

@peyha peyha merged commit 57722cd into main Feb 19, 2025
8 checks passed
@peyha peyha deleted the doc/clarification branch February 19, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants