Remove getJSIModulePackage From Android #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunokiafuka
reviewed
Nov 1, 2024
There was a problem hiding this comment.
@branaust thanks for working on this. Can you please add a description to your PR which contains some testing plan to help our reviewers?
|
Related: #45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Expo apps built with SDK 51 and above are experiencing the following Android build error:
MainApplication.kt:40:9 'getJSIModulePackage' overrides nothingThis error is related to a breaking change introduced in RN .74 release notes:
The goal of this PR:
Remove getJSIModulePackage Dependency: Since getJSIModulePackage has been removed in React Native 0.74, we’ll need to remove this function call from MainApplication.kt in the WatermelonDB plugin.
Switch to TurboModules: With getJSIModulePackage deprecated, the alternative is to configure TurboModules in MainApplication.kt to support WatermelonDB.
Plugin Code Adjustments: In the withWatermelon.js code, remove any direct references to getJSIModulePackage or WatermelonDBJSIPackage for compatibility with the new Android TurboModule requirements.