[Do not merge] Hosted handler for MPT #382
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dskhudia
reviewed
Jun 21, 2023
| @@ -100,7 +100,7 @@ def download_convert(s3_path: Optional[str] = None, | |||
| class MPTFTHostedModelHandler: | |||
| # This is what the user request will contain | |||
| INPUT_GENERATE_KWARGS = { | |||
| 'max_new_tokens': 256, | |||
| 'max_tokens': 256, | |||
There was a problem hiding this comment.
Did we end up on this? It is kind of confusing because it doesn't say whether it's generated or prompt + generated.
There was a problem hiding this comment.
imo it should be max_new_tokens, max_tokens is not very helpful, because your prompt can be longer than 256 and then you just get a 500 from the server.
* Enable CodeQL for pull requests (mosaicml#374) This reverts commit 1a04923. * Update --------- Co-authored-by: bandish-shah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this for review but do not merge