Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: mqtt stream parser #519

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

WIP: mqtt stream parser #519

wants to merge 5 commits into from

Conversation

robertsLando
Copy link
Member

Try to implement the work made by @gnought in his https://github.com/gnought/aedes/tree/next branch

@robertsLando robertsLando marked this pull request as draft July 6, 2020 13:37
@robertsLando
Copy link
Member Author

robertsLando commented Jul 6, 2020 •
edited
Loading

With a quick benchmark seems performances have been incresed by ~10%

@robertsLando robertsLando requested review from gnought and mcollina and removed request for gnought July 6, 2020 16:07
@robertsLando
Copy link
Member Author

@mcollina Could you take a look at this too when you have time ?

mcollina
mcollina requested changes Jul 7, 2020
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will slow us down significantly, I'm -1.

@robertsLando robertsLando mentioned this pull request Oct 13, 2020
Merged
@robertsLando robertsLando mentioned this pull request Oct 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina requested changes

@gnought gnought Awaiting requested review from gnought

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertsLando @mcollina