Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back side is blurred on IOS #46

Open
mkozhukharenko opened this issue Sep 9, 2017 · 11 comments
Open

Back side is blurred on IOS #46

mkozhukharenko opened this issue Sep 9, 2017 · 11 comments

Comments

@mkozhukharenko
Copy link
Contributor

mkozhukharenko commented Sep 9, 2017

I copied and run an example from this project have found next bug: the back side of the card is blured.

giphy

Does anybody know the problem? I'm trying to figure out it...

Platform: IOS
react-native v 47.1
react-native-flip-card v 3.5.1

@mkozhukharenko
Copy link
Contributor Author

mkozhukharenko commented Sep 9, 2017

only text is affected (see http://www.giphy.com/gifs/3ov9jXM7UXfV8pWNUI) (image is still sharp)

@maxperga-zz
Copy link

I can 100% reproduce the problem using the iOS simulator.

@mkozhukharenko
Copy link
Contributor Author

if the perspective property is removed from the style of the Back card - the problem is gone

@mkozhukharenko
Copy link
Contributor Author

on Android everything works fine

@mkozhukharenko
Copy link
Contributor Author

this PR #44 caused an issue

@JKonTiki
Copy link

thanks for the tip @mkozhukharenko , any idea why that was causing the issue?

@mkozhukharenko
Copy link
Contributor Author

3.5.0v don't have such problem. It was introduced but latests commit. See my message

@Gringox
Copy link

Gringox commented Oct 9, 2017

@mkozhukharenko that line you mention is needed for this library to work on certain Android devices, its weird that it blurs text in iOS but maybe the solution could be to add a conditional Platform.OS === 'android' before pushing the perspective prop. Already test it and works.

What do you think? I could make a PR with that.

mkozhukharenko added a commit to mkozhukharenko/react-native-flip-card that referenced this issue Oct 9, 2017
since 'perspective' prop cause the back side on IOS blurred - we can remote it at all (it will affect nothing) and leave only for Android.
@mkozhukharenko
Copy link
Contributor Author

@Gringox I've created MR, can you check it?

@Gringox
Copy link

Gringox commented Oct 9, 2017

Looks good to me @mkozhukharenko.

@mkozhukharenko mkozhukharenko changed the title Back side is blured Back side is blurred on IOS Oct 9, 2017
moschan added a commit that referenced this issue Oct 15, 2017
@moschan
Copy link
Owner

moschan commented Oct 15, 2017

hi! thanks, all and @mkozhukharenko. I bumped new version which contains your MR. Plese check that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants