Huawei, Android 7 fix + Wrapped in Animated View Fix #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed pull request. Flip card now freezes randomly about 10% of the time with error: "Maximum call stack size exceeded" |
|
After some testing I've concluded that the issue was how I was conditionally rendering the card back, and thus had nothing with FlipCard to do. Reopening the pull request. |
|
#46 has occurred after merging this MR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for issues:
#43 , Which turned out to probably be an error specifically for Huawei devices running Android 7. The fix was to push a perspective in the same transforms as the scales in Back. In the fix I use the perspective provided to the FlipCard.
#42 , I added a new prop to flipcard called useNativeDriver. It is set to true by default. When true, however, it seems to break the flipcard when it is provided an animated style, in my case while animating the margins of the style. Enabling the ability to set it to false solves this issue.
Hope this will help. I've tested it in my project and it seems to work fine.