Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOSIP-35902 Corrected Upgrade script #1125

Merged
merged 7 commits into from
Nov 27, 2024

Conversation

kameshsr
Copy link
Contributor

No description provided.

Copy link
Contributor

@dhanendra06 dhanendra06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The detailed comparison reveals the following key differences between the upgrade and rollback scripts:

Alignment of Changes:

The rollback script for master.app_detail corresponds to the operations in the upgrade script but in reverse order, ensuring proper rollback for:
Dropping and re-adding the primary key constraint.
Altering the lang_code column's NOT NULL property.
Scope:

The upgrade script appears to include changes for multiple tables, such as master.biometric_attribute, master.module_detail, and master.template_file_format. However, the rollback script preview only includes operations for master.app_detail.
Differences in Coverage:

It seems that the rollback script is incomplete or limited to a single table, while the upgrade script spans multiple objects.

@kameshsr kameshsr requested a review from dhanendra06 November 26, 2024 12:39
Copy link
Contributor

@dhanendra06 dhanendra06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Modifications:

Data inserted in the upgrade script is not fully accounted for in the rollback script:
Upgrade includes several INSERT statements into master.template_file_format for multiple languages and file formats.
Rollback seems to delete records based on specific id and lang_code criteria, which does not appear to match the INSERT statements in the upgrade.

Missing Elements in Rollback

There are no corresponding DELETE statements for records inserted into master.language and master.template_file_format.
Rollback deletes records from master.template using specific id values, but the upgrade script does not have INSERT statements targeting master.template directly.

@kameshsr kameshsr requested a review from dhanendra06 November 27, 2024 08:09
@Prafulrakhade Prafulrakhade merged commit 57c3c69 into mosip:release-1.2.1.x Nov 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants