MOSIP-28646 code changes (#1757) #1767

sowmya695 · 2023-09-04T13:23:43Z

No description provided.

vishwa-vyom · 2023-09-07T05:36:53Z

...stage/src/main/java/io/mosip/registration/processor/abis/handler/stage/AbisHandlerStage.java

+			biometricModalitySegmentsMap = biometricModalitySegmentsMapforAgeGroup.get(ageGroup);
+			}
+		else {
+			biometricModalitySegmentsMap = biometricModalitySegmentsMapforAgeGroup.get("DEFAULT");


if the map does not contain default age group, how are we handling that ?

For Else condition we assumed always DEFAULT should be present and proceeded without adding any null check.

As discussed, @sowmya695 to create a Jira ticket to handle this case.

Co-authored-by: Sowmya Ujjappa Banakar <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

MOSIP-28445 Removed DB health check for camel Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

Co-authored-by: Sowmya Ujjappa Banakar <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

* [MOSIP-29167]added reusable workflow * [MOSIP-29167]added reusable workflow * [MOSIP-29167]added reusable workflow * [MOSIP-29167]added reusable workflow * [MOSIP-29167]added reusable workflow * [MOSIP-29167]added reusable workflow Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

Co-authored-by: Sowmya Ujjappa Banakar <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

Signed-off-by: Sowmya Ujjappa Banakar <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

…time from metadata of the packet Signed-off-by: khuddus shariff <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

…cket date and time from metadata of the packet Signed-off-by: khuddus shariff <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

) * MOSIP-28185 registration confirmation notification corrected Signed-off-by: Sowmya Ujjappa Banakar <[email protected]> * MOSIP-28185 code fix for packet validator Signed-off-by: Sowmya Ujjappa Banakar <[email protected]> --------- Signed-off-by: Sowmya Ujjappa Banakar <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]> Co-authored-by: Sowmya Ujjappa Banakar <[email protected]> Co-authored-by: Sowmya Ujjappa Banakar <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

Signed-off-by: Rakshithb1 <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

Signed-off-by: Monobikash Das <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

…time from metadata of the packet (mosip#1795) Signed-off-by: khuddus shariff <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

…ger.yml file (mosip#1809) Signed-off-by: techno-467 <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

* MOSIP-29935 Code changes Signed-off-by: Sowmya Ujjappa Banakar <[email protected]> * MOSIP-29935 intial changes after new approach Signed-off-by: Sowmya Ujjappa Banakar <[email protected]> * MOSIP-29935 code fix Signed-off-by: Sowmya Ujjappa Banakar <[email protected]> * MOSIP-29935 code fix Signed-off-by: Sowmya Ujjappa Banakar <[email protected]> * MOSIp-29935 code fix after testing Signed-off-by: Sowmya Ujjappa Banakar <[email protected]> --------- Signed-off-by: Sowmya Ujjappa Banakar <[email protected]> Co-authored-by: Sowmya Ujjappa Banakar <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

Signed-off-by: Rakshith B <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

…equestor Signed-off-by: Monobikash Das <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

Signed-off-by: Sowmya Ujjappa Banakar <[email protected]> Co-authored-by: Sowmya Ujjappa Banakar <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

…records which are not processed Signed-off-by: khuddus shariff <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

Signed-off-by: khuddus shariff <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

… to be change Signed-off-by: khuddus shariff <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

…osip/registration/processor/core/status/util/StatusUtil.java Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

Signed-off-by: khuddus shariff <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

Signed-off-by: Monobikash Das <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

* [MOSIP-29167]added reusable workflow * [MOSIP-29167]added reusable workflow * [MOSIP-29167]added reusable workflow * [MOSIP-29167]added reusable workflow * [MOSIP-29167]added reusable workflow * [MOSIP-29167]added reusable workflow Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

…cket date and time from metadata of the packet Signed-off-by: khuddus shariff <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

Signed-off-by: Monobikash Das <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

…ger.yml file (mosip#1809) Signed-off-by: techno-467 <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

sowmya695 · 2024-02-08T07:09:01Z

closing and reopen another pr to solve sign off,https://github.com/mosip/registration/pull/1845/files
because sign off causing lot of conflicts

MOSIP-28646 code changes (#1757) refer previous pr #1767

vishwa-vyom requested changes Sep 7, 2023

View reviewed changes

sowmya695 force-pushed the MOSIP-28646_develop branch 2 times, most recently from 7c82838 to 2ef8a29 Compare February 8, 2024 06:50

sowmya695 and others added 27 commits February 8, 2024 12:20

MOSIP-28646 code changes (mosip#1757)

64c7db8

Co-authored-by: Sowmya Ujjappa Banakar <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

[DSD-3341]Updated Dockerfile (mosip#1769)

6841128

Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

Merge pull request mosip#1752 from sowmya695/health_check_camel

45e6e53

MOSIP-28445 Removed DB health check for camel Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

Merge pull request mosip#1753 from sowmya695/MOSIP-28478

1356989

Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

MOSIP-28559 trying one approach (mosip#1772)

35adfe8

Co-authored-by: Sowmya Ujjappa Banakar <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

quality checker level tags more specific

068fe6f

Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

Added levels to test MOSIP-29419

0c22afd

Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

Added levels to test MOSIP-29419

f521584

Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

quality checker level tags more specific MOSIP-29419

246e905

Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

MOSIP-28185 Code fix for notification (mosip#1782)

760d1ab

Co-authored-by: Sowmya Ujjappa Banakar <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

MOSIP-29118 Code fix (mosip#1763)

544de1d

Co-authored-by: Sowmya Ujjappa Banakar <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

MOSIP-29780 code fix

5973f01

Signed-off-by: Sowmya Ujjappa Banakar <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

MOSIP-29780 fixed test cases

c698346

Signed-off-by: Sowmya Ujjappa Banakar <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

[ MOSIP-27859 ] Adding pkt_cr_dtimes and setting the packet date and …

4129b36

…time from metadata of the packet Signed-off-by: khuddus shariff <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

[Mosip-27859] [ MOSIP-29896 ] Adding pkt_cr_dtimes and setting the pa…

511b6f9

…cket date and time from metadata of the packet Signed-off-by: khuddus shariff <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

[Mosip-27859] [ MOSIP-29896 ] Adding pkt_cr_dtimes and setting the pa…

5a92ae9

…cket date and time from metadata of the packet Signed-off-by: khuddus shariff <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

[MOSIP-29918] added db-test.yml (mosip#1792)

a0bc2fc

Signed-off-by: Rakshithb1 <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

MOSIP-28121 : opencrvs stage funationalities moved to common stage

ad8019a

Signed-off-by: Monobikash Das <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

MOSIP-28121 : renamed print stage to event handler stage

79ad4b3

Signed-off-by: Monobikash Das <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

MOSIP-28121 : Fixed review comments

2e30c59

Signed-off-by: Monobikash Das <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

MOSIP-28121 : Fixed review comments

28adb2f

Signed-off-by: Monobikash Das <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

MOSIP-28121 : added partner profile feature

58699c5

Signed-off-by: Monobikash Das <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

MOSIP-28121 : added partner profile feature

ad9d5ed

Signed-off-by: Monobikash Das <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

[ MOSIP-29896 ] Adding pkt_cr_dtimes and setting the packet date and …

6d381e0

…time from metadata of the packet (mosip#1795) Signed-off-by: khuddus shariff <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

[DSD-3932] removed release-changes.yml, tag.yml and updated push-trig…

fdb2bea

…ger.yml file (mosip#1809) Signed-off-by: techno-467 <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

sowmya695 and others added 16 commits February 8, 2024 12:20

[MOSIP-29961] removed paths from db-test.yml (mosip#1816)

c25d9a2

Signed-off-by: Rakshith B <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

MOSIP-28121 : calling idrepo instead of packetmanager in credential r…

9461e0e

…equestor Signed-off-by: Monobikash Das <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

MOSIP-31016 code changes (mosip#1824)

3705801

Signed-off-by: Sowmya Ujjappa Banakar <[email protected]> Co-authored-by: Sowmya Ujjappa Banakar <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

[Mosip-28440] changes to compare the biometric records only with the …

5eeb229

…records which are not processed Signed-off-by: khuddus shariff <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

[Mosip-30241] triming the demographic data based on the property

446c284

Signed-off-by: khuddus shariff <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

[Mosip-30241] triming the demographic data based on the property

db0b9e8

Signed-off-by: khuddus shariff <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

[Mosip-30417] Regproc -Landing zone config property naming convention…

c89f2d6

… to be change Signed-off-by: khuddus shariff <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

registration-processor/registration-processor-core/src/main/java/io/m…

9ef455c

…osip/registration/processor/core/status/util/StatusUtil.java Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

[Mosip-30241]adding trim functionality based on property (mosip#1837)

b538a44

Signed-off-by: khuddus shariff <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

Added credential requestor documentation (mosip#1842)

0af8fe8

Signed-off-by: Monobikash Das <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

[Mosip-27859] [ MOSIP-29896 ] Adding pkt_cr_dtimes and setting the pa…

3895d4a

…cket date and time from metadata of the packet Signed-off-by: khuddus shariff <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

MOSIP-28121 : opencrvs stage funationalities moved to common stage

c80486e

Signed-off-by: Monobikash Das <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

MOSIP-28121 : renamed print stage to event handler stage

dfcb865

Signed-off-by: Monobikash Das <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

[DSD-3932] removed release-changes.yml, tag.yml and updated push-trig…

bb824b9

…ger.yml file (mosip#1809) Signed-off-by: techno-467 <[email protected]> Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

sowmya695 force-pushed the MOSIP-28646_develop branch from 2ef8a29 to bb824b9 Compare February 8, 2024 06:51

merged from upstream

a05eecc

Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>

sowmya695 closed this Feb 8, 2024

vishwa-vyom added a commit that referenced this pull request Feb 8, 2024

Merge pull request #1845 from sowmya695/MOSIP-28646_recent

7542e26

MOSIP-28646 code changes (#1757) refer previous pr #1767

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MOSIP-28646 code changes (#1757) #1767

MOSIP-28646 code changes (#1757) #1767

sowmya695 commented Sep 4, 2023

vishwa-vyom Sep 7, 2023

sowmya695 Sep 7, 2023

vishwa-vyom Feb 8, 2024

sowmya695 commented Feb 8, 2024

MOSIP-28646 code changes (#1757) #1767

MOSIP-28646 code changes (#1757) #1767

Conversation

sowmya695 commented Sep 4, 2023

vishwa-vyom Sep 7, 2023

Choose a reason for hiding this comment

sowmya695 Sep 7, 2023

Choose a reason for hiding this comment

vishwa-vyom Feb 8, 2024

Choose a reason for hiding this comment

sowmya695 commented Feb 8, 2024