MOSIP-34112 code changes #1895
MOSIP-34112 code changes #1895
Conversation
Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>
| @@ -132,6 +133,9 @@ public class BioDedupeProcessor { | |||
| @Value("${registration.processor.missing.biometric.verification.enabled:true}") | |||
| private boolean missingBiometricVerificationEnabled; | |||
|
|
|||
| @Value("${registration.processor.biometric.autoreject.enabled:false}") | |||
| private boolean biometricAutorejectEnable; | |||
There was a problem hiding this comment.
I think auto reject is two words and camel case to be corrected.
There was a problem hiding this comment.
Lets rename as below.
registration.processor.biometrics-update.single-match.auto-reject.enabled
biometricsUpdateSingleMatchAutoReject
| @@ -435,6 +439,36 @@ private void postAbisIdentification(InternalRegistrationStatusDto registrationSt | |||
| registrationStatusDto.getRegistrationId(), BioDedupeConstants.ABIS_RESPONSE_NULL); | |||
|
|
|||
| } else { | |||
| if (registrationType.equalsIgnoreCase(RegistrationType.UPDATE.name()) && matchedRegIds.size() == 1 | |||
There was a problem hiding this comment.
what if the matchedRegIds size is 4 and all belongs to the same UIN ?
| && biometricAutorejectEnable) { | ||
| Optional<String> optionalMatchedRegId = matchedRegIds.stream().findFirst(); | ||
| String matchedRegId = optionalMatchedRegId.get(); | ||
| String uin = idRepoService.getUinByRid(matchedRegId, utilities.getGetRegProcessorDemographicIdentity()); |
There was a problem hiding this comment.
If the RID is not latest (lets assume last RID for that user was demographic update), will idrepo still give the correct UIN ?
There was a problem hiding this comment.
On this line one more question, what if this RID was partially processed and UIN is not yet associated. In that case. what will the method return ?
| .setLatestTransactionStatusCode(RegistrationTransactionStatusCode.FAILED.toString()); | ||
| object.setIsValid(Boolean.FALSE); | ||
| registrationStatusDto.setStatusCode(RegistrationStatusCode.REJECTED.name()); | ||
| registrationStatusDto.setStatusComment(StatusUtil.UPDATE_PACKET_BIOMETRICS_NOT_FOUND.getMessage()); |
There was a problem hiding this comment.
This case is not about matching with someone else biometrics ? But message says biometrics not found ?
| BioDedupeConstants.NO_MATCH_FOUND_FOR_UPDATE + registrationStatusDto.getRegistrationId()); | ||
| } | ||
|
|
||
| }else { | ||
| registrationStatusDto.setStatusCode(RegistrationStatusCode.FAILED.name()); | ||
| registrationStatusDto.setStatusComment(StatusUtil.BIO_DEDUPE_POTENTIAL_MATCH.getMessage()); |
There was a problem hiding this comment.
How are we planning to handle this case, where there is more than one match and the country does not have a manual adjudication system ?
Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>
Signed-off-by: Sowmya Ujjappa Banakar <[email protected]>
* MOSIP-34112 code changes Signed-off-by: Sowmya Ujjappa Banakar <[email protected]> * MOSIP-34112 code changes Signed-off-by: Sowmya Ujjappa Banakar <[email protected]> * MOSIP-34112 code changes Signed-off-by: Sowmya Ujjappa Banakar <[email protected]> --------- Signed-off-by: Sowmya Ujjappa Banakar <[email protected]> Co-authored-by: Sowmya Ujjappa Banakar <[email protected]> Signed-off-by: khuddus shariff <[email protected]>
No description provided.