[MOSIP-34112] Release 1.2.0.x code marge for Bio-dedupes updated flow #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khuddusshariff0022
changed the title
* MOSIP-34112 code changes Signed-off-by: Sowmya Ujjappa Banakar <[email protected]> * MOSIP-34112 code changes Signed-off-by: Sowmya Ujjappa Banakar <[email protected]> * MOSIP-34112 code changes Signed-off-by: Sowmya Ujjappa Banakar <[email protected]> --------- Signed-off-by: Sowmya Ujjappa Banakar <[email protected]> Co-authored-by: Sowmya Ujjappa Banakar <[email protected]> Signed-off-by: khuddus shariff <[email protected]>
* [MOSIO-34112] Adding test cases Signed-off-by: khuddus shariff <[email protected]> --------- Signed-off-by: khuddus shariff <[email protected]>
Signed-off-by: khuddus shariff <[email protected]>
Khuddusshariff0022
force-pushed
the
release-1.2.0.x_code_marge
branch
from
44a34ac to
1fbd947
Compare
Signed-off-by: khuddus shariff <[email protected]>
Signed-off-by: khuddus shariff <[email protected]>
Signed-off-by: khuddus shariff <[email protected]>
Signed-off-by: khuddus shariff <[email protected]>
ashok-ksharma
approved these changes
Aug 2, 2024
vishwa-vyom
requested changes
Aug 2, 2024
...-stage/src/main/java/io/mosip/registration/processor/biodedupe/stage/BioDedupeProcessor.java
Outdated
Show resolved
Hide resolved
...ge/src/test/java/io/mosip/registration/processor/biodedupe/stage/BioDedupeProcessorTest.java
Show resolved
Hide resolved
...ge/src/test/java/io/mosip/registration/processor/biodedupe/stage/BioDedupeProcessorTest.java
Show resolved
Hide resolved
...ge/src/test/java/io/mosip/registration/processor/biodedupe/stage/BioDedupeProcessorTest.java
Show resolved
Hide resolved
Signed-off-by: khuddus shariff <[email protected]>
Signed-off-by: khuddus shariff <[email protected]>
ashok-ksharma
approved these changes
Aug 3, 2024
vishwa-vyom
approved these changes
Aug 4, 2024
There was a problem hiding this comment.
Since we have a time crunch and we have the open review comments only on the unit test case, approving for now and expecting the comments to be handled as a different JIRA task.
Comments to be discussed:
#1901 (comment)
#1901 (comment)
This was referenced Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.