Prevent deadlock in RobustChannel.reopen()

mosquito · Mar 16, 2024 · 20071c2 · 20071c2
1 parent a3ef44b
commit 20071c2
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/aio_pika/channel.py b/aio_pika/channel.py
@@ -153,12 +153,12 @@ def __str__(self) -> str:
         return "{}".format(self.number or "Not initialized channel")
 
     async def _open(self) -> None:
-        await self._connection.ready()
-
         transport = self._connection.transport
         if transport is None:
             raise ChannelInvalidStateError("No active transport in channel")
 
+        await transport.ready()
+
         channel = await UnderlayChannel.create(
             transport.connection,
             self._on_close,

diff --git a/aio_pika/robust_channel.py b/aio_pika/robust_channel.py
@@ -111,8 +111,8 @@ async def __close_callback(self, _: Any, exc: BaseException) -> None:
 
         await self.restore()
 
-    async def _open(self) -> None:
-        await super()._open()
+    async def reopen(self) -> None:
+        await super().reopen()
         await self.reopen_callbacks()
 
     async def _on_open(self) -> None:

diff --git a/tests/test_amqp_robust_proxy.py b/tests/test_amqp_robust_proxy.py
@@ -565,6 +565,7 @@ async def test_channel_reconnect_after_5kb(
 
         assert messages
 
+    assert on_reconnect.is_set()
     await connection.close()
     await direct_connection.close()
 
@@ -689,5 +690,6 @@ async def test_channel_reconnect_stairway(
 
         assert messages
 
+    assert on_reconnect.is_set()
     await connection.close()
     await direct_connection.close()