Add handling for invalid commands in main.cc #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a default case to the switch statement in the main function to handle invalid commands. This improves user experience by providing guidance when an invalid command is used.
|
The protobuf shutdown was placed wrong it seems. Maybe remove it for now. Or save the return value in a variable so you can return it after protobuf shutdown. |
|
Hi @felixguendling , I have added a commit that introduces a new variable to return after the protobuf shutdown |
The protobuf shutdown was previously never called, given that all switch cases returned before it. This commit introduces a new variable to store the return value to store the command execution, and returns after the proper shutdown of the Protobuf library to prevent resource leaks
|
My bad! Fixed. |
|
thank you! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor change
Description
This PR improves the user experience by adding handling for invalid commands in
exe/main.cc. When a user enters an unrecognized command, the program will now print "Invalid command. Type motis --help for a list of commands."