Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch unknown arguments and refer to help page #19

Merged
merged 6 commits into from
Mar 8, 2025

Conversation

jbruechert
Copy link
Contributor

Contains a number of updates to get it to build in separate commits.

Using fmt::runtime as a workaround there, I wasn't able to figure out
which change caused the compiler to complain about command not being a
constexpr.
@jbruechert jbruechert changed the title Unknown argument Catch unknown arguments and refer to help page Mar 8, 2025
@jbruechert
Copy link
Contributor Author

Can I merge myself?

@felixguendling
Copy link
Member

Windows build seems to be broken.

D:\a\pkg\pkg\test\doctest.h(3891): error C2039: 'uncaught_exception': is not a member of 'std'

Maybe just #include <stdexcept> or similar before doctest.h?

@jbruechert jbruechert force-pushed the unknown-argument branch 2 times, most recently from 9d7eb47 to 5943d9a Compare March 8, 2025 19:22
@felixguendling
Copy link
Member

Seems this was fixed upstream
doctest/doctest#333

Long term it would probably be better to move everything to GTest so we have only one framework.

@felixguendling
Copy link
Member

Wrong button.. sorry. Didn't intend to close.

@jbruechert
Copy link
Contributor Author

Meh uncaught_exception is removed in C++20

@felixguendling
Copy link
Member

Meh uncaught_exception is removed in C++20

True. Interesting that it doesn't compile.
We're using cxx_std_17.

@jbruechert
Copy link
Contributor Author

Updating doctest helped. I squashed the commits now so the CI will re-run, but it looked good before.

@felixguendling felixguendling merged commit 81b1351 into master Mar 8, 2025
5 of 8 checks passed
@felixguendling felixguendling deleted the unknown-argument branch March 8, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants