Merge upstream 2023 11 11 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugs.webkit.org/show_bug.cgi?id=264380 rdar://118093158 Reviewed by Yusuke Suzuki. Fixing a few "error: comparison of unsigned expression in ‘>= 0’ is always true [-Werror=type-limits]" and "error: suggest parentheses around ‘-’ in operand of ‘&’ [-Werror=parentheses]". * Source/JavaScriptCore/assembler/testmasm.cpp: (JSC::testExtractUnsignedBitfield64): (JSC::testInsertUnsignedBitfieldInZero32): (JSC::testInsertUnsignedBitfieldInZero64): (JSC::testInsertBitField32): (JSC::testInsertBitField64): (JSC::testExtractInsertBitfieldAtLowEnd32): (JSC::testExtractInsertBitfieldAtLowEnd64): (JSC::testClearBitField32): (JSC::testClearBitField64): (JSC::testInsertSignedBitfieldInZero32): (JSC::testInsertSignedBitfieldInZero64): (JSC::testExtractSignedBitfield32): (JSC::testExtractSignedBitfield64): (JSC::testExtractRegister32): (JSC::testExtractRegister64): (JSC::testZeroExtend48ToWord): Canonical link: https://commits.webkit.org/270371@main
https://bugs.webkit.org/show_bug.cgi?id=264348 Reviewed by Wenson Hsieh and Yusuke Suzuki. Avoid sweeping when IncrementalSweeper fires if opportunistic task has been keeping up. This appears to be ~1% progression on JetStream 2. * Source/JavaScriptCore/heap/IncrementalSweeper.cpp: (JSC::IncrementalSweeper::doWork): (JSC::IncrementalSweeper::doSweep): * Source/JavaScriptCore/heap/IncrementalSweeper.h: Canonical link: https://commits.webkit.org/270372@main
…ments with datalist https://bugs.webkit.org/show_bug.cgi?id=264038 rdar://117809656 Reviewed by Richard Robinson and Megan Gardner. Deploy `CompactContextMenuPresenter` in `WKDataListSuggestionsDropdown`, to support compact context menu presentation without relying on UIKit SPI. Note that this (in theory) means we no longer need logic to manually specify preferred edge insets for the suggestions menu, since we now lay out the hidden native `UIButton` over the bounds of the focused datalist element, which UIKit will automatically avoid obscuring when presenting or updating the menu. * Source/WebKit/Platform/spi/ios/UIKitSPI.h: Remove SPI declarations that are no longer necessary. * Source/WebKit/UIProcess/ios/CompactContextMenuPresenter.h: * Source/WebKit/UIProcess/ios/CompactContextMenuPresenter.mm: (WebKit::CompactContextMenuPresenter::updateVisibleMenu): * Source/WebKit/UIProcess/ios/WKContentViewInteraction.h: * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _createTargetedContextMenuHintPreviewForFocusedElement:]): (-[WKContentView _createTargetedContextMenuHintPreviewForFocusedElement]): Deleted. Add support for an option to create a targeted context menu hint that's positioned against the left or right edge of the input, provided there's sufficient space to fit the 250pt (by default) menu. When the view is RTL, note that we'll prefer to position the menu at the the right edge of the element, fall back to the left edge if there's not enough horizonal space, and finally fall back to the element rect itself if there's no space on either side. * Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm: (-[WKDataListSuggestionsDropdown _showSuggestions]): (-[WKDataListSuggestionsDropdown _removeContextMenuInteraction]): (-[WKDataListSuggestionsDropdown contextMenuInteraction:configuration:highlightPreviewForItemWithIdentifier:]): (-[WKDataListSuggestionsDropdown _preferredEdgeInsetsForSuggestionsMenu]): Deleted. (-[WKDataListSuggestionsDropdown _contextMenuInteraction:styleForMenuWithConfiguration:]): Deleted. * Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm: (-[WKSelectPicker contextMenuInteraction:configuration:highlightPreviewForItemWithIdentifier:]): Canonical link: https://commits.webkit.org/270373@main
https://bugs.webkit.org/show_bug.cgi?id=264366 Reviewed by Dan Glastonbury. The transition to all Cocoa platforms having NSURLSessionWebSocketTask is complete. This removes dead code and some unneeded abstractions like allowing all TLS for WebSockets. * Source/WTF/wtf/PlatformHave.h: * Source/WebKit/NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::setAllowsAnySSLCertificateForWebSocket): Deleted. * Source/WebKit/NetworkProcess/NetworkProcess.h: * Source/WebKit/NetworkProcess/NetworkProcess.messages.in: * Source/WebKit/NetworkProcess/NetworkSession.cpp: (WebKit::m_shouldAcceptInsecureCertificatesForWebSockets): Deleted. * Source/WebKit/NetworkProcess/NetworkSession.h: * Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.cpp: (WebKit::NetworkSessionCreationParameters::encode): (WebKit::NetworkSessionCreationParameters::decode): * Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h: * Source/WebKit/NetworkProcess/NetworkSocketChannel.cpp: (WebKit::NetworkSocketChannel::NetworkSocketChannel): (WebKit::NetworkSocketChannel::~NetworkSocketChannel): * Source/WebKit/NetworkProcess/WebSocketTask.h: * Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h: * Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm: (-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]): (-[WKNetworkSessionDelegate sessionFromTask:]): (-[WKNetworkSessionDelegate URLSession:webSocketTask:didCloseWithCode:reason:]): (WebKit::SessionWrapper::recreateSessionWithUpdatedProxyConfigurations): (WebKit::NetworkSessionCocoa::continueDidReceiveChallenge): * Source/WebKit/NetworkProcess/cocoa/WebSocketTaskCocoa.h: * Source/WebKit/NetworkProcess/cocoa/WebSocketTaskCocoa.mm: * Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp: (WKWebsiteDataStoreSetAllowsAnySSLCertificateForWebSocketTesting): * Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm: (-[_WKWebsiteDataStoreConfiguration _shouldAcceptInsecureCertificatesForWebSockets]): (-[_WKWebsiteDataStoreConfiguration _setShouldAcceptInsecureCertificatesForWebSockets:]): * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::parameters): (WebKit::WebsiteDataStore::setAllowsAnySSLCertificateForWebSocket): Deleted. * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h: * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp: (WebKit::WebsiteDataStoreConfiguration::copy const): * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h: (WebKit::WebsiteDataStoreConfiguration::shouldAcceptInsecureCertificatesForWebSockets const): Deleted. (WebKit::WebsiteDataStoreConfiguration::setShouldAcceptInsecureCertificatesForWebSockets): Deleted. * Source/WebKitLegacy/WebCoreSupport/SocketStreamHandleImplCFNet.cpp: (WebCore::SocketStreamHandleImpl::createStreams): * Tools/TestWebKitAPI/Tests/WebKitCocoa/WebSocket.mm: (TestWebKitAPI::TEST): * Tools/WebKitTestRunner/TestController.cpp: (WTR::TestController::setAllowsAnySSLCertificate): * Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::setAllowsAnySSLCertificate): Canonical link: https://commits.webkit.org/270374@main
https://bugs.webkit.org/show_bug.cgi?id=243947 rdar://problem/98992367 Reviewed by Jonathan Bedard. Changes to logic so git revert is no longer a blank template. Also prevents git-webkit revert from affecting future commits on main. A better commit message for git revert is in the works! * Tools/Scripts/hooks/prepare-commit-msg: * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/revert.py: (Revert): * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/revert_unittest.py: (TestRevert.test_github): (TestRevert.test_github_two_step): (test_update): Canonical link: https://commits.webkit.org/270375@main
https://bugs.webkit.org/show_bug.cgi?id=264250 rdar://117996144 Reviewed by Alan Baradlay. Cache the final CSSValue for variable references in all cases. * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/css/CSSPendingSubstitutionValue.cpp: Added. (WebCore::CSSPendingSubstitutionValue::resolveValue const): For shortcut references cache each individual longhand. * Source/WebCore/css/CSSPendingSubstitutionValue.h: * Source/WebCore/css/CSSVariableReferenceValue.cpp: (WebCore::CSSVariableReferenceValue::cacheSimpleReference): (WebCore::CSSVariableReferenceValue::resolveSingleValue const): (WebCore::CSSVariableReferenceValue::resolveAndCacheValue const): Deleted. (WebCore::CSSVariableReferenceValue::resolveSubstitutionValue const): Deleted. * Source/WebCore/css/CSSVariableReferenceValue.h: (WebCore::CSSVariableReferenceValue::resolveAndCacheValue const): Cache also in non-simple reference case. In these cases we still resolve the tokens and use their equaivalence to test the validity of the cached value. * Source/WebCore/style/StyleBuilder.cpp: (WebCore::Style::Builder::resolveVariableReferences): Canonical link: https://commits.webkit.org/270376@main
https://bugs.webkit.org/show_bug.cgi?id=264274 Reviewed by Michael Catanzaro. Provide serialization input file for the WebKit::PrintInfo struct, removing the need for custom encode/decode methods. For the GTK port, the PrintMode enumeration is turned into the scoped equivalent along with the necessary changes at points of use. ArgumentCoder specializations are also provided for the two types that are GRefPtr-wrapped. * Source/WebKit/CMakeLists.txt: * Source/WebKit/Shared/PrintInfo.cpp: (WebKit::PrintInfo::PrintInfo): (WebKit::PrintInfo::encode const): Deleted. (WebKit::PrintInfo::decode): Deleted. * Source/WebKit/Shared/PrintInfo.h: * Source/WebKit/Shared/PrintInfo.serialization.in: Added. * Source/WebKit/Shared/gtk/ArgumentCodersGtk.cpp: (IPC::ArgumentCoder<GRefPtr<GtkPrintSettings>>::encode): (IPC::ArgumentCoder<GRefPtr<GtkPrintSettings>>::decode): (IPC::ArgumentCoder<GRefPtr<GtkPageSetup>>::encode): (IPC::ArgumentCoder<GRefPtr<GtkPageSetup>>::decode): (IPC::encode): Deleted. (IPC::decode): Deleted. * Source/WebKit/Shared/gtk/ArgumentCodersGtk.h: * Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp: (webkitWebViewPrintFrame): * Source/WebKit/UIProcess/API/gtk/WebKitPrintOperation.cpp: (webkitPrintOperationPrintPagesForFrame): * Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp: (WebKit::WebPrintOperationGtk::PrintPagesData::PrintPagesData): (WebKit::WebPrintOperationGtk::print): * Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.h: Canonical link: https://commits.webkit.org/270377@main
https://bugs.webkit.org/show_bug.cgi?id=264029 Reviewed by Chris Dumez. * Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.cpp: (WebKit::SimulatedInputDispatcher::transitionToNextInputSourceState): * Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp: (WebKit::WebAutomationSession::performInteractionSequence): (WebKit::WebAutomationSession::cancelInteractionSequence): * Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm: (WebKit::VideoPresentationManagerProxy::createModelAndInterface): (WebKit::VideoPresentationManagerProxy::removeClientForContext): (WebKit::VideoPresentationManagerProxy::requestBitmapImageForCurrentTime): (WebKit::VideoPresentationManagerProxy::enterFullscreen): * Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm: (WebKit::WebPasteboardProxy::didModifyContentsOfPasteboard): (WebKit::WebPasteboardProxy::setPasteboardURL): (WebKit::WebPasteboardProxy::determineDataOwner const): * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingTreeMac.mm: (WebKit::RemoteScrollingTreeMac::handleWheelEventPhase): (WebKit::isScrolledBy): (WebKit::RemoteScrollingTreeMac::scrollingNodeForPoint): * Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp: (WebKit::UserMediaPermissionRequestManagerProxy::grantRequest): (WebKit::UserMediaPermissionRequestManagerProxy::finishGrantingRequest): (WebKit::UserMediaPermissionRequestManagerProxy::getRequestAction): (WebKit::UserMediaPermissionRequestManagerProxy::startProcessingUserMediaPermissionRequest): (WebKit::UserMediaPermissionRequestManagerProxy::processUserMediaPermissionRequest): (WebKit::UserMediaPermissionRequestManagerProxy::decidePolicyForUserMediaPermissionRequest): (WebKit::UserMediaPermissionRequestManagerProxy::captureStateChanged): * Source/WebKit/UIProcess/UserMediaPermissionRequestProxy.h: (WebKit::UserMediaPermissionRequestProxy::protectedTopLevelDocumentSecurityOrigin const): (WebKit::UserMediaPermissionRequestProxy::protectedUserMediaDocumentSecurityOrigin const): * Source/WebKit/UIProcess/UserMediaProcessManager.cpp: (WebKit::UserMediaProcessManager::willCreateMediaStream): * Source/WebKit/UIProcess/WebContextMenuProxy.cpp: (WebKit::WebContextMenuProxy::show): * Source/WebKit/UIProcess/WebGeolocationManagerProxy.cpp: (WebKit::connectionToWebProcessProxy): Canonical link: https://commits.webkit.org/270378@main
https://bugs.webkit.org/show_bug.cgi?id=264368 <rdar://problem/118081884> Reviewed by Justin Michaud. This change rewords SyntaxError message, thrown in case of generator method parsing failure, to mention "method" rather than "function", aligning error wording for sync generator functions with async counterparts. Also, tweaks the helper to return "generator function" instead of "generator" for GeneratorBodyMode, which is unobservable yet matches the terminology of the spec [1]. [1]: https://tc39.es/ecma262/#sec-generator-objects * JSTests/stress/generator-class-methods-syntax.js: * JSTests/stress/regress-189292.js: * Source/JavaScriptCore/parser/Parser.cpp: (JSC::stringForFunctionMode): Canonical link: https://commits.webkit.org/270379@main
https://bugs.webkit.org/show_bug.cgi?id=264347 rdar://118066101 Reviewed by Dan Glastonbury. This removes the remaining pieces of WebGL diagnostic logging, in particular for context loss and some remaining constants. * Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::WebGLRenderingContextBase): (WebCore::WebGLRenderingContextBase::checkForContextLossHandling): Deleted. * Source/WebCore/html/canvas/WebGLRenderingContextBase.h: * Source/WebCore/page/DiagnosticLoggingKeys.cpp: (WebCore::DiagnosticLoggingKeys::pageHandlesWebGLContextLossKey): Deleted. (WebCore::DiagnosticLoggingKeys::inactiveKey): Deleted. (WebCore::DiagnosticLoggingKeys::activeInForegroundTabKey): Deleted. (WebCore::DiagnosticLoggingKeys::activeInBackgroundTabOnlyKey): Deleted. * Source/WebCore/page/DiagnosticLoggingKeys.h: Canonical link: https://commits.webkit.org/270380@main
…e web view https://bugs.webkit.org/show_bug.cgi?id=264225 Reviewed by Alejandro G. Castro. This way we can use the same implementation for GTK3 and GTK4. * Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp: (_WebKitWebViewBasePrivate::_WebKitWebViewBasePrivate): (_WebKitWebViewBasePrivate::nextPresentationUpdateTimerFired): (webkitWebViewBaseNextPresentationUpdateMonitorStart): (webkitWebViewBaseNextPresentationUpdateMonitorStop): (webkitWebViewBaseNextPresentationUpdateFrame): (webkitWebViewBaseDispose): (webkitWebViewBaseSnapshot): (webkitWebViewBaseDraw): (webkitWebViewBaseCallAfterNextPresentationUpdate): * Source/WebKit/UIProcess/API/gtk/WebKitWebViewBasePrivate.h: * Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp: (WebKit::DrawingAreaProxyCoordinatedGraphics::DrawingMonitor::DrawingMonitor): (WebKit::DrawingAreaProxyCoordinatedGraphics::DrawingMonitor::start): (WebKit::DrawingAreaProxyCoordinatedGraphics::DrawingMonitor::stop): (WebKit::DrawingAreaProxyCoordinatedGraphics::DrawingMonitor::webViewDrawCallback): Deleted. (WebKit::DrawingAreaProxyCoordinatedGraphics::DrawingMonitor::didDraw): Deleted. * Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: * Source/WebKit/UIProcess/gtk/WebPageProxyGtk.cpp: (WebKit::WebPageProxy::callAfterNextPresentationUpdate): Canonical link: https://commits.webkit.org/270381@main
https://bugs.webkit.org/show_bug.cgi?id=264365 Reviewed by Kimmo Kinnunen. Enabled support for the following approved extensions: * EXT_clip_control * EXT_depth_clamp * EXT_polygon_offset_clamp * WEBGL_polygon_mode * LayoutTests/platform/ios-simulator/webgl/webgl-draft-extensions-flag-default-expected.txt: * LayoutTests/platform/ios-simulator/webgl/webgl-draft-extensions-flag-on-expected.txt: * LayoutTests/webgl/resources/webgl-draft-extensions-flag.js: * LayoutTests/webgl/webgl-draft-extensions-flag-default-expected.txt: * LayoutTests/webgl/webgl-draft-extensions-flag-off-expected.txt: * LayoutTests/webgl/webgl-draft-extensions-flag-on-expected.txt: * Source/WebCore/html/canvas/WebGL2RenderingContext.cpp: (WebCore::WebGL2RenderingContext::getExtension): (WebCore::WebGL2RenderingContext::getSupportedExtensions): * Source/WebCore/html/canvas/WebGLPolygonMode.cpp: (WebCore::WebGLPolygonMode::WebGLPolygonMode): * Source/WebCore/html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getExtension): (WebCore::WebGLRenderingContext::getSupportedExtensions): * Source/WebCore/html/canvas/WebGLRenderingContextBase.h: Canonical link: https://commits.webkit.org/270382@main
https://bugs.webkit.org/show_bug.cgi?id=264363 rdar://117854010 Reviewed by Dan Glastonbury. Validation was not working at submission time as the encoder state was never changed from Open to Locked. * Source/WebGPU/WebGPU/CommandEncoder.h: * Source/WebGPU/WebGPU/CommandEncoder.mm: (WebGPU::CommandEncoder::beginComputePass): (WebGPU::CommandEncoder::beginRenderPass): (WebGPU::CommandEncoder::lock): * Source/WebGPU/WebGPU/ComputePassEncoder.h: (WebGPU::ComputePassEncoder::create): * Source/WebGPU/WebGPU/ComputePassEncoder.mm: (WebGPU::ComputePassEncoder::ComputePassEncoder): (WebGPU::ComputePassEncoder::endPass): * Source/WebGPU/WebGPU/RenderPassEncoder.h: (WebGPU::RenderPassEncoder::create): * Source/WebGPU/WebGPU/RenderPassEncoder.mm: (WebGPU::RenderPassEncoder::RenderPassEncoder): (WebGPU::RenderPassEncoder::endPass): Canonical link: https://commits.webkit.org/270383@main
https://bugs.webkit.org/show_bug.cgi?id=264395 Unreviewed gardening. This test requires memory that exceeds the limit when running with --memory-limited. * JSTests/stress/intl-data-time-format-string-overflow.js: Canonical link: https://commits.webkit.org/270384@main
https://bugs.webkit.org/show_bug.cgi?id=264093 rdar://117854457 Reviewed by Elliott Williams. * Source/WebKit/DerivedSources.make: * Source/WebKit/Scripts/compile-sandbox.sh: Added. Canonical link: https://commits.webkit.org/270385@main
https://bugs.webkit.org/show_bug.cgi?id=264364 Reviewed by Chris Dumez. 255698@main added serializer for the struct Cookie, including WebCore::Cookie::SameSitePolicy, but the EnumTraits was never removed. * Source/WebCore/platform/Cookie.h: Canonical link: https://commits.webkit.org/270386@main
https://bugs.webkit.org/show_bug.cgi?id=264396 Unreviewed gardening. * JSTests/stress/fold-multi-get-by-offset-to-get-by-offset.js: Canonical link: https://commits.webkit.org/270387@main
… threads https://bugs.webkit.org/show_bug.cgi?id=264090 Reviewed by Alejandro G. Castro. If there's an async scrolling request the compositing thread might be busy just waiting for the painting threads. We can wait for them in the main thread, which is already expected to be blocked painting. * Source/WebCore/platform/graphics/nicosia/NicosiaBackingStore.cpp: (Nicosia::BackingStore::waitUntilPaintingComplete): * Source/WebCore/platform/graphics/nicosia/NicosiaBackingStore.h: * Source/WebCore/platform/graphics/nicosia/NicosiaCompositionLayer.h: * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp: (WebCore::CoordinatedBackingStoreTile::swapBuffers): * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp: (WebKit::CompositingCoordinator::flushPendingLayerChanges): * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp: (WebKit::LayerTreeHost::LayerTreeHost): (WebKit::LayerTreeHost::scheduleLayerFlush): (WebKit::LayerTreeHost::layerFlushTimerFired): (WebKit::LayerTreeHost::forceRepaint): (WebKit::LayerTreeHost::forceRepaintAsync): (WebKit::LayerTreeHost::commitSceneState): (WebKit::LayerTreeHost::didRenderFrame): (WebKit::LayerTreeHost::handleDisplayRefreshMonitorUpdate): (WebKit::LayerTreeHost::renderNextFrame): (WebKit::LayerTreeHost::didRenderFrameTimerFired): Deleted. * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h: Canonical link: https://commits.webkit.org/270388@main
https://bugs.webkit.org/show_bug.cgi?id=264332 Reviewed by Nikolas Zimmermann. Update some test results after 270302@main. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/batik/text/textEffect2-expected.txt: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/batik/text/textProperties-expected.txt: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/text-clip-expected.txt: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/filters/filter-clip-expected.txt: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/foreignObject/clip-expected.txt: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/repaint/mask-clip-target-transform-expected.txt: Canonical link: https://commits.webkit.org/270389@main
https://bugs.webkit.org/show_bug.cgi?id=264146 rdar://problem/117899460 Reviewed by Youenn Fablet. There were two existing methods used to notify the SourceBufferPrivate that the MediaSource was ended (through a call to MediaSource::endOfStream()): - SourceBuffer::readyStateChanged - SourceBuffer::setMediaSourceEnded and both were duplicated in SourceBufferPrivate classes, though the SourceBufferPrivateGStreamer used setMediaSourceEnded, while the others used readyStateChanged. They conveyed the same information. We remove SourceBuffer::readyStateChanged and adopt setMediaSourceEnded everywhere. Also, by recalculating the buffered range when SourceBufferPrivate is notified we can remove the two IPC loops between the GPU process and the content process simply to update at the end the buffered ranges. Covered by existing tests, no change in observable behaviour. * Source/WebCore/Modules/mediasource/MediaSource.cpp: (WebCore::MediaSource::streamEndedWithError): (WebCore::MediaSource::onReadyStateChange): No longer needs to notify the SourceBuffers. * Source/WebCore/Modules/mediasource/SourceBuffer.cpp: (WebCore::SourceBuffer::appendBufferInternal): (WebCore::SourceBuffer::removeTimerFired): (WebCore::SourceBuffer::memoryPressure): (WebCore::SourceBuffer::readyStateChanged): Deleted. * Source/WebCore/Modules/mediasource/SourceBuffer.h: * Source/WebCore/platform/graphics/SourceBufferPrivate.cpp: (WebCore::SourceBufferPrivate::updateBufferedFromTrackBuffers): (WebCore::SourceBufferPrivate::appendCompleted): (WebCore::SourceBufferPrivate::processAppendCompletedOperation): (WebCore::SourceBufferPrivate::clearTrackBuffers): (WebCore::SourceBufferPrivate::setMediaSourceEnded): (WebCore::SourceBufferPrivate::removeCodedFrames): (WebCore::SourceBufferPrivate::evictCodedFrames): (WebCore::SourceBufferPrivate::memoryPressure): (WebCore::SourceBufferPrivate::evictFrames): (WebCore::SourceBufferPrivate::clientReadyStateChanged): Deleted. * Source/WebCore/platform/graphics/SourceBufferPrivate.h: (WebCore::SourceBufferPrivate::removeCodedFrames): (WebCore::SourceBufferPrivate::updateBufferedFromTrackBuffers): (WebCore::SourceBufferPrivate::appendCompleted): * Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm: (WebCore::SourceBufferPrivateAVFObjC::appendCompleted): * Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp: (WebCore::SourceBufferPrivateGStreamer::didReceiveAllPendingSamples): (WebCore::SourceBufferPrivateGStreamer::appendParsingFailed): * Source/WebCore/platform/mock/mediasource/MockSourceBufferPrivate.cpp: (WebCore::MockSourceBufferPrivate::appendInternal): * Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.cpp: (WebKit::RemoteSourceBufferProxy::removeCodedFrames): (WebKit::RemoteSourceBufferProxy::evictCodedFrames): (WebKit::RemoteSourceBufferProxy::memoryPressure): (WebKit::RemoteSourceBufferProxy::clientReadyStateChanged): Deleted. * Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.h: * Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.messages.in: * Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.cpp: (WebKit::SourceBufferPrivateRemote::setMediaSourceEnded): (WebKit::SourceBufferPrivateRemote::removeCodedFrames): (WebKit::SourceBufferPrivateRemote::evictCodedFrames): (WebKit::SourceBufferPrivateRemote::memoryPressure): (WebKit::SourceBufferPrivateRemote::clientReadyStateChanged): Deleted. * Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.h: Canonical link: https://commits.webkit.org/270390@main
…tate.cpp, and ImageControlsMac.cpp https://bugs.webkit.org/show_bug.cgi?id=264389 Reviewed by Chris Dumez. Deploy smart pointers as warned by the clang static analyzer. * Source/WebCore/dom/UserTypingGestureIndicator.cpp: (WebCore::UserTypingGestureIndicator::UserTypingGestureIndicator): * Source/WebCore/dom/VisitedLinkState.cpp: (WebCore::linkAttribute): (WebCore::VisitedLinkState::invalidateStyleForAllLinks): (WebCore::VisitedLinkState::invalidateStyleForLink): (WebCore::VisitedLinkState::determineLinkStateSlowCase): * Source/WebCore/dom/VisitedLinkState.h: * Source/WebCore/dom/mac/ImageControlsMac.cpp: (WebCore::ImageControlsMac::createImageControls): (WebCore::ImageControlsMac::handleEvent): Canonical link: https://commits.webkit.org/270391@main
…UserGestureIndicator.cpp https://bugs.webkit.org/show_bug.cgi?id=264393 Reviewed by Chris Dumez. Deploy smart pointers as warned by the clang static analyzer. * Source/WebCore/dom/TreeScope.cpp: (WebCore::TreeScope::labelElementsForId): (WebCore::TreeScope::elementFromPoint): (WebCore::TreeScope::findAnchor): * Source/WebCore/dom/TreeScope.h: * Source/WebCore/dom/TreeScopeInlines.h: (WebCore::TreeScope::protectedRootNode const): * Source/WebCore/dom/TreeScopeOrderedMap.cpp: (WebCore::TreeScopeOrderedMap::get const): (WebCore::TreeScopeOrderedMap::getAll const): * Source/WebCore/dom/UserGestureIndicator.cpp: (WebCore::UserGestureToken::UserGestureToken): Canonical link: https://commits.webkit.org/270392@main
https://bugs.webkit.org/show_bug.cgi?id=264372 rdar://117727308 Reviewed by David Kilzer. The code was doing an early return in this case: ``` if (!usesReportTo && !is<Document>(m_scriptExecutionContext)) return; ``` Then proceeding to downcast m_scriptExecutionContext to a Document. This meant we would do a bad cast in the case where usesReportTo is true. * Source/WebCore/page/csp/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::reportViolation const): Canonical link: https://commits.webkit.org/270393@main
https://bugs.webkit.org/show_bug.cgi?id=264417 Introduced build failure Reverted changeset: "Create script to compile sandboxes" https://bugs.webkit.org/show_bug.cgi?id=264093 https://commits.webkit.org/270385@main Canonical link: https://commits.webkit.org/270394@main
https://bugs.webkit.org/show_bug.cgi?id=264416 Reviewed by Jonathan Bedard. Updates method name when called to match def. * Tools/Scripts/hooks/prepare-commit-msg: Canonical link: https://commits.webkit.org/270395@main
https://bugs.webkit.org/show_bug.cgi?id=264378 Reviewed by Simon Fraser. * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::createObjectFromRenderer): * Source/WebCore/accessibility/AccessibilityList.cpp: (WebCore::AccessibilityList::determineAccessibilityRole): * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::isMeter const): * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::boundingBoxRect const): (WebCore::AccessibilityRenderObject::supportsPath const): (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored const): (WebCore::AccessibilityRenderObject::setValue): (WebCore::AccessibilityRenderObject::renderObjectIsObservable const): (WebCore::AccessibilityRenderObject::determineAccessibilityRole): * Source/WebCore/accessibility/AccessibilitySVGElement.cpp: (WebCore::AccessibilitySVGElement::description const): (WebCore::AccessibilitySVGElement::computeAccessibilityIsIgnored const): (WebCore::AccessibilitySVGElement::determineAccessibilityRole): * Source/WebCore/accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySliderThumb::elementRect const): * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::positionOffsetValue): (WebCore::paddingOrMarginIsRendererDependent): (WebCore::positionOffsetValueIsRendererDependent): (WebCore::isFlexOrGridItem): * Source/WebCore/dom/Document.cpp: (WebCore::Document::updateHoverActiveState): * Source/WebCore/dom/Element.cpp: (WebCore::Element::clientWidth): (WebCore::Element::clientHeight): * Source/WebCore/editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded): * Source/WebCore/editing/Editing.cpp: (WebCore::isBlock): (WebCore::isTableStructureNode): (WebCore::isFirstPositionAfterTable): (WebCore::isLastPositionBeforeTable): (WebCore::isListItem): (WebCore::isRenderedTable): (WebCore::isTableCell): (WebCore::isRenderedAsNonInlineTableImageOrHR): * Source/WebCore/editing/Editor.cpp: (WebCore::findFirstMarkable): * Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): * Source/WebCore/editing/ModifySelectionListLevel.cpp: (WebCore::getStartEndListChildren): * Source/WebCore/editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): * Source/WebCore/editing/TextIterator.cpp: (WebCore::ignoresContainerClip): (WebCore::isRendererReplacedElement): (WebCore::shouldEmitNewlinesBeforeAndAfterNode): (WebCore::TextIterator::shouldRepresentNodeOffsetZero): (WebCore::TextIterator::shouldEmitSpaceBeforeAndAfterNode): * Source/WebCore/editing/TypingCommand.cpp: (WebCore::TypingCommand::forwardDeleteKeyPressed): * Source/WebCore/html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::rendererIsNeeded): * Source/WebCore/html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::willRespondToMouseClickEventsWithEditability const): * Source/WebCore/html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::updateListBoxSelection): (WebCore::HTMLSelectElement::menuListDefaultEventHandler): (WebCore::HTMLSelectElement::defaultEventHandler): * Source/WebCore/html/shadow/SliderThumbElement.cpp: (WebCore::RenderSliderContainer::computeLogicalHeight const): * Source/WebCore/inspector/InspectorOverlay.cpp: (WebCore::buildRendererHighlight): * Source/WebCore/layout/formattingContexts/inline/InlineLevelBoxInlines.h: * Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp: (WebCore::Layout::LineBoxBuilder::setVerticalPropertiesForInlineLevelBox const): * Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp: (WebCore::Layout::LineBuilder::candidateContentForLine): * Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp: (WebCore::Layout::InlineDisplayContentBuilder::appendInlineBoxDisplayBox): (WebCore::Layout::InlineDisplayContentBuilder::appendSpanningInlineBoxDisplayBox): (WebCore::Layout::InlineDisplayContentBuilder::handleInlineBoxEnd): (WebCore::Layout::InlineDisplayContentBuilder::appendRubyAnnotationBox): (WebCore::Layout::InlineDisplayContentBuilder::applyRubyOverhang): * Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp: (WebCore::Layout::nextWrapOpportunityWithinRubyContainer): (WebCore::Layout::RubyFormattingContext::placeRubyContent): (WebCore::Layout::RubyFormattingContext::placeAnnotationBox): (WebCore::Layout::RubyFormattingContext::sizeAnnotationBox): (WebCore::Layout::RubyFormattingContext::applyAnnotationContributionToLayoutBounds const): (WebCore::Layout::RubyFormattingContext::nextWrapOpportunity): (WebCore::Layout::RubyFormattingContext::annotationOverlapCheck const): (WebCore::Layout::RubyFormattingContext::logicaWidthForRubyRange const): * Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp: (WebCore::LayoutIntegration::canUseForChild): (WebCore::LayoutIntegration::canUseForLineLayoutWithReason): (WebCore::LayoutIntegration::canUseForFlexLayout): * Source/WebCore/layout/integration/inline/InlineIteratorLineBox.cpp: (WebCore::InlineIterator::closestBoxForHorizontalPosition): * Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp: (WebCore::LayoutIntegration::isContentRenderer): (WebCore::LayoutIntegration::LineLayout::containing): * Source/WebCore/layout/layouttree/LayoutBox.h: (WebCore::Layout::Box::isRenderRubyBase const): (WebCore::Layout::Box::isRubyBase const): Deleted. * Source/WebCore/page/AutoscrollController.cpp: (WebCore::AutoscrollController::startAutoscrollForSelection): * Source/WebCore/page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDraggedEvent): (WebCore::EventHandler::updateSelectionForMouseDrag): (WebCore::EventHandler::scrollOverflow): (WebCore::EventHandler::logicalScrollOverflow): (WebCore::EventHandler::startKeyboardScrollAnimationOnEnclosingScrollableContainer): * Source/WebCore/page/LocalFrameView.cpp: (WebCore::LocalFrameView::scrollToFocusedElementInternal): * Source/WebCore/page/ios/FrameIOS.mm: (WebCore::LocalFrame::nodeRespondingToScrollWheelEvents): * Source/WebCore/rendering/CaretRectComputation.cpp: (WebCore::computeCaretRectForText): (WebCore::computeCaretRectForBox): * Source/WebCore/rendering/HitTestResult.cpp: (WebCore::HitTestResult::mediaElement const): * Source/WebCore/rendering/LegacyInlineBox.cpp: (WebCore::LegacyInlineBox::logicalHeight const): * Source/WebCore/rendering/LegacyInlineBox.h: (WebCore::LegacyInlineBox::isLineBreak const): * Source/WebCore/rendering/LegacyInlineFlowBox.cpp: (WebCore::LegacyInlineFlowBox::addToLine): (WebCore::verticalAlignApplies): * Source/WebCore/rendering/LegacyInlineIterator.h: (WebCore::isIteratorTarget): (WebCore::LegacyInlineIterator::direction const): * Source/WebCore/rendering/LegacyInlineTextBox.cpp: (WebCore::LegacyInlineTextBox::isRenderLineBreak const): (WebCore::LegacyInlineTextBox::nodeAtPoint): (WebCore::LegacyInlineTextBox::paint): (WebCore::LegacyInlineTextBox::selectableRange const): (WebCore::LegacyInlineTextBox::expansionBehavior const): (WebCore::LegacyInlineTextBox::isLineBreak const): Deleted. * Source/WebCore/rendering/LegacyLineLayout.cpp: (WebCore::LegacyLineLayout::constructLine): (WebCore::LegacyLineLayout::setMarginsForRubyRun): (WebCore::LegacyLineLayout::computeExpansionForJustifiedText): (WebCore::isLastInFlowRun): (WebCore::LegacyLineLayout::computeInlineDirectionPositionsForSegment): (WebCore::LegacyLineLayout::createLineBoxesFromBidiRuns): (WebCore::LegacyLineLayout::layoutLineBoxes): * Source/WebCore/rendering/LegacyRootInlineBox.cpp: (WebCore::LegacyRootInlineBox::selectionTop const): (WebCore::LegacyRootInlineBox::selectionBottom const): (WebCore::LegacyRootInlineBox::ascentAndDescentForBox const): (WebCore::LegacyRootInlineBox::verticalPositionForBox): (WebCore::LegacyRootInlineBox::includeLeadingForBox const): (WebCore::LegacyRootInlineBox::includeFontForBox const): (WebCore::LegacyRootInlineBox::includeGlyphsForBox const): (WebCore::LegacyRootInlineBox::includeInitialLetterForBox const): (WebCore::LegacyRootInlineBox::includeMarginForBox const): * Source/WebCore/rendering/RenderAttachment.cpp: (WebCore::RenderAttachment::RenderAttachment): * Source/WebCore/rendering/RenderAttachment.h: * Source/WebCore/rendering/RenderBlock.cpp: (WebCore::RenderBlock::isSelfCollapsingBlock const): (WebCore::RenderBlock::isSelectionRoot const): (WebCore::RenderBlock::paintSelection): (WebCore::RenderBlock::selectionGaps): (WebCore::RenderBlock::blockSelectionGaps): (WebCore::RenderBlock::hitTestContents): (WebCore::RenderBlock::positionForPoint): (WebCore::RenderBlock::computePreferredLogicalWidths): (WebCore::RenderBlock::computeBlockPreferredLogicalWidths const): (WebCore::RenderBlock::computeChildPreferredLogicalWidths const): (WebCore::RenderBlock::baselinePosition const): (WebCore::RenderBlock::firstLineBaseline const): (WebCore::RenderBlock::lastLineBaseline const): (WebCore::RenderBlock::inlineBlockBaseline const): * Source/WebCore/rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::MarginInfo::MarginInfo): (WebCore::RenderBlockFlow::rebuildFloatingObjectSetFromIntrudingFloats): (WebCore::RenderBlockFlow::willCreateColumns const): (WebCore::RenderBlockFlow::layoutBlock): (WebCore::RenderBlockFlow::marginBeforeEstimateForChild const): (WebCore::RenderBlockFlow::adjustBlockChildForPagination): (WebCore::RenderBlockFlow::computeLineAdjustmentForPagination): (WebCore::RenderBlockFlow::firstLineBaseline const): (WebCore::RenderBlockFlow::lastLineBaseline const): (WebCore::RenderBlockFlow::inlineBlockBaseline const): (WebCore::RenderBlockFlow::inlineSelectionGaps): (WebCore::RenderBlockFlow::positionForPointWithInlineChildren): (WebCore::isNonBlocksOrNonFixedHeightListItems): (WebCore::InlineMinMaxIterator::next): (WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths const): * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::RenderBox): (WebCore::RenderBox::computeBackgroundIsKnownToBeObscured): (WebCore::RenderBox::computeVisibleRectInContainer const): (WebCore::RenderBox::computeLogicalWidthInFragment const): (WebCore::RenderBox::isStretchingColumnFlexItem const): (WebCore::RenderBox::sizesLogicalWidthToFitContent const): (WebCore::RenderBox::overrideLogicalHeightForSizeContainment): (WebCore::RenderBox::computeLogicalHeight const): (WebCore::RenderBox::skipContainingBlockForPercentHeightCalculation const): (WebCore::RenderBox::computePercentageLogicalHeight const): (WebCore::RenderBox::computeReplacedLogicalHeightUsing const): (WebCore::RenderBox::availableLogicalHeightUsing const): (WebCore::RenderBox::computeBlockDirectionMargins const): (WebCore::RenderBox::containingBlockLogicalHeightForPositioned const): (WebCore::RenderBox::computePositionedLogicalHeightUsing const): (WebCore::RenderBox::positionForPoint): * Source/WebCore/rendering/RenderBox.h: * Source/WebCore/rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::RenderBoxModelObject): (WebCore::RenderBoxModelObject::containingBlockForAutoHeightDetection const): (WebCore::RenderBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight const): (WebCore::RenderBoxModelObject::computeStickyPositionConstraints const): * Source/WebCore/rendering/RenderBoxModelObject.h: (WebCore::RenderBoxModelObject::canHaveBoxInfoInFragment const): * Source/WebCore/rendering/RenderCombineText.cpp: (WebCore::RenderCombineText::RenderCombineText): * Source/WebCore/rendering/RenderCombineText.h: * Source/WebCore/rendering/RenderCounter.cpp: (WebCore::RenderCounter::RenderCounter): * Source/WebCore/rendering/RenderCounter.h: * Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp: (WebCore::RenderDeprecatedFlexibleBox::layoutBlock): * Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h: * Source/WebCore/rendering/RenderDetailsMarker.cpp: (WebCore::RenderDetailsMarker::RenderDetailsMarker): * Source/WebCore/rendering/RenderDetailsMarker.h: * Source/WebCore/rendering/RenderElement.cpp: (WebCore::RenderElement::layerCreationAllowedForSubtree const): (WebCore::RenderElement::adjustComputedFontSizesOnBlocks): (WebCore::RenderElement::resetTextAutosizing): (WebCore::RenderElement::createsNewFormattingContext const): (WebCore::RenderElement::referenceBoxRect const): * Source/WebCore/rendering/RenderElement.h: (WebCore::RenderElement::isDeprecatedFlexItem const): (WebCore::RenderElement::isRenderBoxModelObject const): (WebCore::RenderObject::isRenderBoxModelObject const): (WebCore::RenderObject::isFlexibleBoxIncludingDeprecated const): (WebCore::RenderObject::style const): (WebCore::RenderObject::firstLineStyle const): (WebCore::RenderObject::isSkippedContentRoot const): (WebCore::RenderElement::isBoxModelObject const): Deleted. (WebCore::RenderObject::isBoxModelObject const): Deleted. * Source/WebCore/rendering/RenderElementInlines.h: (WebCore::RenderElement::canContainAbsolutelyPositionedObjects const): (WebCore::RenderElement::canContainFixedPositionObjects const): (WebCore::RenderElement::shouldApplyLayoutOrPaintContainment const): (WebCore::RenderElement::shouldApplySizeOrStyleContainment const): * Source/WebCore/rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::RenderEmbeddedObject): * Source/WebCore/rendering/RenderEmbeddedObject.h: * Source/WebCore/rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::RenderFileUploadControl): * Source/WebCore/rendering/RenderFileUploadControl.h: * Source/WebCore/rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::computeChildIntrinsicLogicalWidths const): (WebCore::isSVGRootWithIntrinsicAspectRatio): (WebCore::RenderFlexibleBox::computeMainSizeFromAspectRatioUsing const): (WebCore::RenderFlexibleBox::computeFlexItemMinMaxSizes): * Source/WebCore/rendering/RenderFragmentedFlow.cpp: (WebCore::RenderFragmentedFlow::objectShouldFragmentInFlowFragment const): (WebCore::RenderFragmentedFlow::objectInFlowFragment const): * Source/WebCore/rendering/RenderFrame.cpp: (WebCore::RenderFrame::RenderFrame): * Source/WebCore/rendering/RenderFrame.h: * Source/WebCore/rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::RenderFrameSet): (WebCore::RenderFrameSet::layout): (WebCore::RenderFrameSet::isChildAllowed const): * Source/WebCore/rendering/RenderFrameSet.h: * Source/WebCore/rendering/RenderGeometryMap.cpp: (WebCore::canMapBetweenRenderersViaLayers): * Source/WebCore/rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::RenderHTMLCanvas): * Source/WebCore/rendering/RenderHTMLCanvas.h: * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::shouldBeNormalFlowOnly const): (WebCore::RenderLayer::referenceBoxRectForClipPath const): (WebCore::expandClipRectForDescendantsAndReflection): (WebCore::RenderLayer::beginTransparencyLayers): (WebCore::RenderLayer::convertToLayerCoords const): (WebCore::RenderLayer::shouldTryToScrollForScrollIntoView const): (WebCore::RenderLayer::paintLayerByApplyingTransform): (WebCore::RenderLayer::enclosingSVGRootLayer const): (WebCore::RenderLayer::calculateClipRects const): * Source/WebCore/rendering/RenderLayer.h: (WebCore::RenderLayer::isReflection const): * Source/WebCore/rendering/RenderLayerBacking.cpp: (WebCore::canvasCompositingStrategy): (WebCore::RenderLayerBacking::createPrimaryGraphicsLayer): (WebCore::RenderLayerBacking::shouldSetContentsDisplayDelegate const): (WebCore::RenderLayerBacking::updateVideoGravity): (WebCore::RenderLayerBacking::updateContentsScalingFilters): (WebCore::RenderLayerBacking::contentChanged): (WebCore::RenderLayerBacking::startAnimation): * Source/WebCore/rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements): (WebCore::RenderLayerCompositor::requiresCompositingForCanvas const): * Source/WebCore/rendering/RenderLayerInlines.h: (WebCore::RenderLayer::canUseOffsetFromAncestor const): * Source/WebCore/rendering/RenderLayerModelObject.cpp: (WebCore::rendererNeedsPixelSnapping): * Source/WebCore/rendering/RenderLayerScrollableArea.cpp: (WebCore::RenderLayerScrollableArea::createOrDestroyMarquee): (WebCore::RenderLayerScrollableArea::isScrollCornerVisible const): (WebCore::RenderLayerScrollableArea::updateScrollbarsAfterLayout): * Source/WebCore/rendering/RenderLineBreak.cpp: (WebCore::RenderLineBreak::RenderLineBreak): (WebCore::RenderLineBreak::collectSelectionGeometries): * Source/WebCore/rendering/RenderLineBreak.h: * Source/WebCore/rendering/RenderListBox.h: (isType): * Source/WebCore/rendering/RenderListItem.cpp: (WebCore::RenderListItem::RenderListItem): * Source/WebCore/rendering/RenderListItem.h: * Source/WebCore/rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::RenderListMarker): (WebCore::RenderListMarker::addOverflowFromListMarker): * Source/WebCore/rendering/RenderListMarker.h: * Source/WebCore/rendering/RenderMedia.h: * Source/WebCore/rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::RenderMenuList): * Source/WebCore/rendering/RenderMenuList.h: * Source/WebCore/rendering/RenderMeter.cpp: (WebCore::RenderMeter::RenderMeter): * Source/WebCore/rendering/RenderMeter.h: * Source/WebCore/rendering/RenderObject.cpp: (WebCore::objectIsRelayoutBoundary): (WebCore::RenderObject::invalidateContainerPreferredLogicalWidths): (WebCore::RenderObject::collectSelectionGeometriesInternal): * Source/WebCore/rendering/RenderObject.h: (WebCore::RenderObject::isRenderElement const): (WebCore::RenderObject::isRenderCounter const): (WebCore::RenderObject::isRenderQuote const): (WebCore::RenderObject::isRenderDetailsMarker const): (WebCore::RenderObject::isRenderEmbeddedObject const): (WebCore::RenderObject::isRenderFileUploadControl const): (WebCore::RenderObject::isRenderFrame const): (WebCore::RenderObject::isRenderFrameSet const): (WebCore::RenderObject::isRenderListBox const): (WebCore::RenderObject::isRenderListItem const): (WebCore::RenderObject::isRenderListMarker const): (WebCore::RenderObject::isRenderMedia const): (WebCore::RenderObject::isRenderMenuList const): (WebCore::RenderObject::isRenderMeter const): (WebCore::RenderObject::isRenderProgress const): (WebCore::RenderObject::isRenderTextFragment const): (WebCore::RenderObject::isRenderReplica const): (WebCore::RenderObject::isRenderRubyAsInline const): (WebCore::RenderObject::isRenderRubyAsBlock const): (WebCore::RenderObject::isRenderRubyBase const): (WebCore::RenderObject::isRenderRubyRun const): (WebCore::RenderObject::isRenderRubyText const): (WebCore::RenderObject::isRenderSlider const): (WebCore::RenderObject::isRenderTableCell const): (WebCore::RenderObject::isRenderTableCaption const): (WebCore::RenderObject::isRenderTableSection const): (WebCore::RenderObject::isRenderTextControlMultiLine const): (WebCore::RenderObject::isRenderTextControlSingleLine const): (WebCore::RenderObject::isRenderSearchField const): (WebCore::RenderObject::isRenderTextControlInnerBlock const): (WebCore::RenderObject::isRenderVideo const): (WebCore::RenderObject::isRenderWidget const): (WebCore::RenderObject::isRenderHTMLCanvas const): (WebCore::RenderObject::isRenderAttachment const): (WebCore::RenderObject::isTablePart const): (WebCore::RenderObject::isLegacyRenderSVGRoot const): (WebCore::RenderObject::isRenderSVGRoot const): (WebCore::RenderObject::isRenderSVGContainer const): (WebCore::RenderObject::isLegacyRenderSVGContainer const): (WebCore::RenderObject::isRenderSVGTransformableContainer const): (WebCore::RenderObject::isLegacyRenderSVGTransformableContainer const): (WebCore::RenderObject::isRenderSVGViewportContainer const): (WebCore::RenderObject::isLegacyRenderSVGViewportContainer const): (WebCore::RenderObject::isRenderSVGGradientStop const): (WebCore::RenderObject::isLegacyRenderSVGHiddenContainer const): (WebCore::RenderObject::isRenderSVGHiddenContainer const): (WebCore::RenderObject::isLegacyRenderSVGPath const): (WebCore::RenderObject::isRenderSVGPath const): (WebCore::RenderObject::isRenderSVGShape const): (WebCore::RenderObject::isLegacyRenderSVGShape const): (WebCore::RenderObject::isRenderSVGText const): (WebCore::RenderObject::isRenderSVGTextPath const): (WebCore::RenderObject::isRenderSVGTSpan const): (WebCore::RenderObject::isRenderSVGInline const): (WebCore::RenderObject::isRenderSVGInlineText const): (WebCore::RenderObject::isLegacyRenderSVGImage const): (WebCore::RenderObject::isRenderSVGImage const): (WebCore::RenderObject::isLegacyRenderSVGForeignObject const): (WebCore::RenderObject::isRenderSVGForeignObject const): (WebCore::RenderObject::isLegacyRenderSVGResourceContainer const): (WebCore::RenderObject::isRenderSVGResourceContainer const): (WebCore::RenderObject::isRenderSVGResourceFilter const): (WebCore::RenderObject::isLegacyRenderSVGResourceClipper const): (WebCore::RenderObject::isRenderSVGResourceClipper const): (WebCore::RenderObject::isRenderSVGResourceFilterPrimitive const): (WebCore::RenderObject::isRenderOrLegacyRenderSVGRoot const): (WebCore::RenderObject::isRenderOrLegacyRenderSVGShape const): (WebCore::RenderObject::isRenderOrLegacyRenderSVGPath const): (WebCore::RenderObject::isRenderOrLegacyRenderSVGImage const): (WebCore::RenderObject::isRenderOrLegacyRenderSVGForeignObject const): (WebCore::RenderObject::isSVGLayerAwareRenderer const): (WebCore::RenderObject::hasIntrinsicAspectRatio const): (WebCore::RenderObject::shouldUsePositionedClipping const): (WebCore::RenderObject::isRenderText const): (WebCore::RenderObject::isRenderLineBreak const): (WebCore::RenderObject::isBR const): (WebCore::RenderObject::isLineBreakOpportunity const): (WebCore::RenderObject::isRenderTextOrLineBreak const): (WebCore::RenderObject::isRenderBox const): (WebCore::RenderObject::isRenderTableRow const): (WebCore::RenderObject::setIsRenderText): (WebCore::RenderObject::setIsRenderBox): (WebCore::RenderObject::isRenderDeprecatedFlexibleBox const): (WebCore::RenderObject::isRenderCombineText const): (WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields): (WebCore::RenderObject::isBeforeContent const): (WebCore::RenderObject::isAfterContent const): (WebCore::RenderObject::isAnonymousBlock const): (WebCore::RenderObject::setPositionState): (WebCore::RenderObject::isRenderTable const): (WebCore::RenderObject::isCounter const): Deleted. (WebCore::RenderObject::isQuote const): Deleted. (WebCore::RenderObject::isDetailsMarker const): Deleted. (WebCore::RenderObject::isEmbeddedObject const): Deleted. (WebCore::RenderObject::isFileUploadControl const): Deleted. (WebCore::RenderObject::isFrame const): Deleted. (WebCore::RenderObject::isFrameSet const): Deleted. (WebCore::RenderObject::isListBox const): Deleted. (WebCore::RenderObject::isListItem const): Deleted. (WebCore::RenderObject::isListMarker const): Deleted. (WebCore::RenderObject::isMedia const): Deleted. (WebCore::RenderObject::isMenuList const): Deleted. (WebCore::RenderObject::isMeter const): Deleted. (WebCore::RenderObject::isProgress const): Deleted. (WebCore::RenderObject::isTextFragment const): Deleted. (WebCore::RenderObject::isReplica const): Deleted. (WebCore::RenderObject::isRubyInline const): Deleted. (WebCore::RenderObject::isRubyBlock const): Deleted. (WebCore::RenderObject::isRubyBase const): Deleted. (WebCore::RenderObject::isRubyRun const): Deleted. (WebCore::RenderObject::isRubyText const): Deleted. (WebCore::RenderObject::isSlider const): Deleted. (WebCore::RenderObject::isTableCell const): Deleted. (WebCore::RenderObject::isTableCaption const): Deleted. (WebCore::RenderObject::isTableSection const): Deleted. (WebCore::RenderObject::isTextArea const): Deleted. (WebCore::RenderObject::isTextField const): Deleted. (WebCore::RenderObject::isSearchField const): Deleted. (WebCore::RenderObject::isTextControlInnerBlock const): Deleted. (WebCore::RenderObject::isVideo const): Deleted. (WebCore::RenderObject::isWidget const): Deleted. (WebCore::RenderObject::isCanvas const): Deleted. (WebCore::RenderObject::isAttachment const): Deleted. (WebCore::RenderObject::isLegacySVGRoot const): Deleted. (WebCore::RenderObject::isSVGRoot const): Deleted. (WebCore::RenderObject::isSVGContainer const): Deleted. (WebCore::RenderObject::isLegacySVGContainer const): Deleted. (WebCore::RenderObject::isSVGTransformableContainer const): Deleted. (WebCore::RenderObject::isLegacySVGTransformableContainer const): Deleted. (WebCore::RenderObject::isSVGViewportContainer const): Deleted. (WebCore::RenderObject::isLegacySVGViewportContainer const): Deleted. (WebCore::RenderObject::isSVGGradientStop const): Deleted. (WebCore::RenderObject::isLegacySVGHiddenContainer const): Deleted. (WebCore::RenderObject::isSVGHiddenContainer const): Deleted. (WebCore::RenderObject::isLegacySVGPath const): Deleted. (WebCore::RenderObject::isSVGPath const): Deleted. (WebCore::RenderObject::isSVGShape const): Deleted. (WebCore::RenderObject::isLegacySVGShape const): Deleted. (WebCore::RenderObject::isSVGText const): Deleted. (WebCore::RenderObject::isSVGTextPath const): Deleted. (WebCore::RenderObject::isSVGTSpan const): Deleted. (WebCore::RenderObject::isSVGInline const): Deleted. (WebCore::RenderObject::isSVGInlineText const): Deleted. (WebCore::RenderObject::isLegacySVGImage const): Deleted. (WebCore::RenderObject::isSVGImage const): Deleted. (WebCore::RenderObject::isLegacySVGForeignObject const): Deleted. (WebCore::RenderObject::isSVGForeignObject const): Deleted. (WebCore::RenderObject::isLegacySVGResourceContainer const): Deleted. (WebCore::RenderObject::isSVGResourceContainer const): Deleted. (WebCore::RenderObject::isSVGResourceFilter const): Deleted. (WebCore::RenderObject::isLegacySVGResourceClipper const): Deleted. (WebCore::RenderObject::isSVGResourceClipper const): Deleted. (WebCore::RenderObject::isSVGResourceFilterPrimitive const): Deleted. (WebCore::RenderObject::isSVGRootOrLegacySVGRoot const): Deleted. (WebCore::RenderObject::isSVGShapeOrLegacySVGShape const): Deleted. (WebCore::RenderObject::isSVGPathOrLegacySVGPath const): Deleted. (WebCore::RenderObject::isSVGImageOrLegacySVGImage const): Deleted. (WebCore::RenderObject::isSVGForeignObjectOrLegacySVGForeignObject const): Deleted. (WebCore::RenderObject::isText const): Deleted. (WebCore::RenderObject::isLineBreak const): Deleted. (WebCore::RenderObject::isTextOrLineBreak const): Deleted. (WebCore::RenderObject::isBox const): Deleted. (WebCore::RenderObject::isTableRow const): Deleted. (WebCore::RenderObject::setIsText): Deleted. (WebCore::RenderObject::setIsBox): Deleted. (WebCore::RenderObject::isDeprecatedFlexibleBox const): Deleted. (WebCore::RenderObject::isCombineText const): Deleted. (WebCore::RenderObject::isTable const): Deleted. * Source/WebCore/rendering/RenderObjectInlines.h: (WebCore::RenderObject::preservesNewline const): * Source/WebCore/rendering/RenderProgress.cpp: (WebCore::RenderProgress::RenderProgress): * Source/WebCore/rendering/RenderProgress.h: * Source/WebCore/rendering/RenderQuote.cpp: (WebCore::RenderQuote::RenderQuote): * Source/WebCore/rendering/RenderQuote.h: * Source/WebCore/rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::computeIntrinsicRatioInformation const): (WebCore::hasIntrinsicSize): * Source/WebCore/rendering/RenderReplica.h: * Source/WebCore/rendering/RenderRuby.cpp: (WebCore::RenderRubyAsInline::RenderRubyAsInline): (WebCore::RenderRubyAsBlock::RenderRubyAsBlock): * Source/WebCore/rendering/RenderRuby.h: * Source/WebCore/rendering/RenderRubyBase.cpp: (WebCore::RenderRubyBase::RenderRubyBase): * Source/WebCore/rendering/RenderRubyBase.h: * Source/WebCore/rendering/RenderRubyRun.cpp: (WebCore::RenderRubyRun::RenderRubyRun): (WebCore::RenderRubyRun::hasRubyText const): (WebCore::RenderRubyRun::hasRubyBase const): (WebCore::RenderRubyRun::rubyText const): (WebCore::RenderRubyRun::rubyBase const): (WebCore::RenderRubyRun::isChildAllowed const): * Source/WebCore/rendering/RenderRubyRun.h: * Source/WebCore/rendering/RenderRubyText.cpp: (WebCore::RenderRubyText::RenderRubyText): * Source/WebCore/rendering/RenderRubyText.h: * Source/WebCore/rendering/RenderSearchField.cpp: (WebCore::RenderSearchField::RenderSearchField): * Source/WebCore/rendering/RenderSearchField.h: * Source/WebCore/rendering/RenderSelection.cpp: (WebCore::RenderSelection::apply): * Source/WebCore/rendering/RenderSlider.cpp: (WebCore::RenderSlider::RenderSlider): * Source/WebCore/rendering/RenderSlider.h: * Source/WebCore/rendering/RenderTable.cpp: (WebCore::RenderTable::RenderTable): (WebCore::RenderTable::paintObject): (WebCore::RenderTable::nodeAtPoint): * Source/WebCore/rendering/RenderTable.h: * Source/WebCore/rendering/RenderTableCaption.cpp: (WebCore::RenderTableCaption::RenderTableCaption): * Source/WebCore/rendering/RenderTableCaption.h: * Source/WebCore/rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::RenderTableCell): * Source/WebCore/rendering/RenderTableCell.h: * Source/WebCore/rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::RenderTableRow): * Source/WebCore/rendering/RenderTableRow.h: * Source/WebCore/rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::RenderTableSection): * Source/WebCore/rendering/RenderTableSection.h: * Source/WebCore/rendering/RenderText.cpp: (WebCore::offsetForPositionInRun): (WebCore::RenderText::RenderText): (WebCore::RenderText::collectSelectionGeometries): (WebCore::RenderText::positionForPoint): (WebCore::containsOffset): (WebCore::RenderText::emphasisMarkExistsAndIsAbove): * Source/WebCore/rendering/RenderText.h: * Source/WebCore/rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine): * Source/WebCore/rendering/RenderTextControlMultiLine.h: * Source/WebCore/rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock): * Source/WebCore/rendering/RenderTextControlSingleLine.h: * Source/WebCore/rendering/RenderTextFragment.h: (isType): * Source/WebCore/rendering/RenderThemeAdwaita.cpp: (WebCore::RenderThemeAdwaita::paintProgressBar): * Source/WebCore/rendering/RenderThemeIOS.mm: (WebCore::RenderThemeIOS::paintMenuListButtonDecorations): (WebCore::RenderThemeIOS::paintMenuListButtonDecorationsWithFormControlRefresh): * Source/WebCore/rendering/RenderTreeAsText.cpp: (WebCore::RenderTreeAsText::writeRenderObject): * Source/WebCore/rendering/RenderVideo.cpp: (WebCore::RenderVideo::RenderVideo): * Source/WebCore/rendering/RenderVideo.h: * Source/WebCore/rendering/RenderView.cpp: (WebCore::RenderView::isChildAllowed const): (WebCore::RenderView::layout): * Source/WebCore/rendering/RenderWidget.h: * Source/WebCore/rendering/TextDecorationPainter.cpp: (WebCore::collectStylesForRenderer): * Source/WebCore/rendering/line/BreakingContext.h: (WebCore::BreakingContext::BreakingContext): (WebCore::BreakingContext::initializeForCurrentObject): (WebCore::BreakingContext::handleText): (WebCore::BreakingContext::canBreakAtThisPosition): (WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded): * Source/WebCore/rendering/svg/RenderSVGContainer.h: * Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::RenderSVGForeignObject): * Source/WebCore/rendering/svg/RenderSVGForeignObject.h: * Source/WebCore/rendering/svg/RenderSVGGradientStop.cpp: (WebCore::RenderSVGGradientStop::RenderSVGGradientStop): * Source/WebCore/rendering/svg/RenderSVGGradientStop.h: * Source/WebCore/rendering/svg/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::RenderSVGHiddenContainer): * Source/WebCore/rendering/svg/RenderSVGHiddenContainer.h: * Source/WebCore/rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::RenderSVGImage): * Source/WebCore/rendering/svg/RenderSVGImage.h: * Source/WebCore/rendering/svg/RenderSVGInline.cpp: (WebCore::RenderSVGInline::RenderSVGInline): * Source/WebCore/rendering/svg/RenderSVGInline.h: * Source/WebCore/rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::RenderSVGInlineText): (WebCore::RenderSVGInlineText::characterStartsNewTextChunk const): * Source/WebCore/rendering/svg/RenderSVGInlineText.h: * Source/WebCore/rendering/svg/RenderSVGModelObject.cpp: (WebCore::isGraphicsElement): * Source/WebCore/rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::RenderSVGPath): * Source/WebCore/rendering/svg/RenderSVGPath.h: * Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::RenderSVGResourceClipper): * Source/WebCore/rendering/svg/RenderSVGResourceClipper.h: * Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer): * Source/WebCore/rendering/svg/RenderSVGResourceContainer.h: * Source/WebCore/rendering/svg/RenderSVGResourceFilter.h: (isType): * Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.h: * Source/WebCore/rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::RenderSVGRoot): (WebCore::RenderSVGRoot::isEmbeddedThroughFrameContainingSVGDocument const): (WebCore::RenderSVGRoot::paintObject): * Source/WebCore/rendering/svg/RenderSVGRoot.h: * Source/WebCore/rendering/svg/RenderSVGShape.h: * Source/WebCore/rendering/svg/RenderSVGTSpan.h: * Source/WebCore/rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::RenderSVGText): (WebCore::RenderSVGText::subtreeChildWasAdded): (WebCore::RenderSVGText::subtreeChildWillBeRemoved): * Source/WebCore/rendering/svg/RenderSVGText.h: * Source/WebCore/rendering/svg/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::RenderSVGTextPath): * Source/WebCore/rendering/svg/RenderSVGTextPath.h: * Source/WebCore/rendering/svg/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::RenderSVGTransformableContainer): * Source/WebCore/rendering/svg/RenderSVGTransformableContainer.h: * Source/WebCore/rendering/svg/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer): * Source/WebCore/rendering/svg/RenderSVGViewportContainer.h: * Source/WebCore/rendering/svg/SVGBoundingBoxComputation.cpp: (WebCore::SVGBoundingBoxComputation::handleRootOrContainer const): * Source/WebCore/rendering/svg/SVGContainerLayout.cpp: (WebCore::SVGContainerLayout::positionChildrenRelativeToContainer): (WebCore::SVGContainerLayout::verifyLayoutLocationConsistency): * Source/WebCore/rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::nodeAtPoint): * Source/WebCore/rendering/svg/SVGLayerTransformComputation.h: (WebCore::SVGLayerTransformComputation::computeAccumulatedTransform const): * Source/WebCore/rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::computeContainerBoundingBoxes): (WebCore::SVGRenderSupport::computeContainerStrokeBoundingBox): (WebCore::SVGRenderSupport::transformToRootChanged): (WebCore::SVGRenderSupport::applyStrokeStyleToContext): * Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeSVGContainer): * Source/WebCore/rendering/svg/SVGRenderingContext.cpp: (WebCore::SVGRenderingContext::prepareToRenderSVGContent): (WebCore::SVGRenderingContext::calculateTransformationToOutermostCoordinateSystem): * Source/WebCore/rendering/svg/SVGResourcesCache.cpp: (WebCore::rendererCanHaveResources): (WebCore::SVGResourcesCache::clientStyleChanged): * Source/WebCore/rendering/svg/SVGResourcesCycleSolver.cpp: (WebCore::SVGResourcesCycleSolver::resourceContainsCycles): * Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::parentDefinesTextLength const): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGContainer.h: * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGForeignObject.cpp: (WebCore::LegacyRenderSVGForeignObject::LegacyRenderSVGForeignObject): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGForeignObject.h: * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGHiddenContainer.h: * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGImage.cpp: (WebCore::LegacyRenderSVGImage::LegacyRenderSVGImage): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGImage.h: * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.cpp: (WebCore::isGraphicsElement): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGPath.cpp: (WebCore::LegacyRenderSVGPath::LegacyRenderSVGPath): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGPath.h: * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResource.cpp: (WebCore::LegacyRenderSVGResource::fillAndStrokePathOrShape const): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.cpp: (WebCore::LegacyRenderSVGResourceClipper::drawContentIntoMaskImage): (WebCore::LegacyRenderSVGResourceClipper::calculateClipContentRepaintRect): (WebCore::LegacyRenderSVGResourceClipper::hitTestClipContent): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.h: (isType): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceContainer.cpp: (WebCore::LegacyRenderSVGResourceContainer::computeTextPaintingScale): (WebCore::LegacyRenderSVGResourceContainer::transformOnNonScalingStroke): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceContainer.h: * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.cpp: (WebCore::LegacyRenderSVGRoot::LegacyRenderSVGRoot): (WebCore::LegacyRenderSVGRoot::paintReplaced): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.h: * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.h: * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGTransformableContainer.cpp: (WebCore::LegacyRenderSVGTransformableContainer::LegacyRenderSVGTransformableContainer): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGTransformableContainer.h: * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGViewportContainer.cpp: (WebCore::LegacyRenderSVGViewportContainer::LegacyRenderSVGViewportContainer): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGViewportContainer.h: * Source/WebCore/rendering/updating/RenderTreeBuilder.cpp: (WebCore::RenderTreeBuilder::attachToRenderElementInternal): (WebCore::RenderTreeBuilder::destroyAndCleanUpAnonymousWrappers): (WebCore::RenderTreeBuilder::detachFromRenderElement): (WebCore::RenderTreeBuilder::reportVisuallyNonEmptyContent): * Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp: (WebCore::canDropAnonymousBlock): (WebCore::RenderTreeBuilder::Block::attachIgnoringContinuation): * Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp: (WebCore::isRubyChildForNormalRemoval): (WebCore::RenderTreeBuilder::Ruby::attach): (WebCore::RenderTreeBuilder::Ruby::findOrCreateParentForChild): (WebCore::RenderTreeBuilder::Ruby::detach): * Source/WebCore/rendering/updating/RenderTreeUpdater.cpp: (WebCore::RenderTreeUpdater::textRendererIsNeeded): * Source/WebCore/svg/SVGElement.cpp: (WebCore::SVGElement::hasAssociatedSVGLayoutBox const): * Source/WebCore/svg/SVGFELightElement.cpp: (WebCore::SVGFELightElement::svgAttributeChanged): * Source/WebCore/svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::invalidateFilterPrimitiveParent): * Source/WebCore/svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::rendererIsNeeded): * Source/WebCore/svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::elementFromRenderer): * Source/WebCore/svg/graphics/SVGImage.cpp: (WebCore::SVGImage::setContainerSize): (WebCore::SVGImage::containerSize const): * Source/WebKit/WebProcess/WebCoreSupport/ShareableBitmapUtilities.cpp: (WebKit::createShareableBitmap): * Source/WebKitLegacy/mac/DOM/DOMUIKitExtensions.mm: (-[DOMNode containsOnlyInlineObjects]): (-[DOMHTMLElement structuralComplexityContribution]): Canonical link: https://commits.webkit.org/270396@main
https://bugs.webkit.org/show_bug.cgi?id=264206 rdar://117944583 Reviewed by Brent Fulgham. WebKit process extensions do not have the same entitlement requirements as XPC services. This patch is an intial step in making that distinction. * Source/WebKit/Scripts/process-entitlements.sh: Canonical link: https://commits.webkit.org/270397@main
https://bugs.webkit.org/show_bug.cgi?id=264422 Unreviewed. WebKit/WebKit#20120 added a new test that fails on iOS because of some unrelated drawing issues that also affect other site-isolation tests. Skip this new test like we do the others until the underlying issue is fixed. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/270398@main
…being drawn. https://bugs.webkit.org/show_bug.cgi?id=264356 <rdar://118034981> Reviewed by Alex Christensen. RemoteLayerBackingStoreCollection::willCommitLayerTree collects all the backing stores that were unreachable, and includes that list in the transaction so that the UI process can ensure the buffer references are removed. This changes moves that call until we've finished building all the transactions, so that were not considering buffers only used in latter transactions to be unreachable for the first transaction. It also adds a new 'willBuildTransaction' function. The set of backing stores that need display is a property of the transaction (where we call prepareBuffersForDisplay, and then paint them), so we want to clear this state per-transaction, not per rendering update. * LayoutTests/http/tests/site-isolation/double-iframe-expected.html: Added. * LayoutTests/http/tests/site-isolation/double-iframe.html: Added. * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.h: * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm: (WebKit::RemoteLayerBackingStoreCollection::willFlushLayers): (WebKit::RemoteLayerBackingStoreCollection::willBuildTransaction): * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm: (WebKit::RemoteLayerTreeDrawingArea::updateRendering): Canonical link: https://commits.webkit.org/270399@main
…nit-tests/iterableweakset.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=264426 rdar://118129008 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/270400@main
https://bugs.webkit.org/show_bug.cgi?id=264659 rdar://118266600 Reviewed by Alexey Shvayka. Convert their prints into silent result checks, and throw on failure. * JSTests/stress/date-set-time-purify-nan.js: * JSTests/stress/regress-109102631.js: Canonical link: https://commits.webkit.org/270592@main
https://bugs.webkit.org/show_bug.cgi?id=264398 Reviewed by Philippe Normand. When playing video in a loop using HTML5 video element, the Gstreamer debug log sometimes contains the following message, which prevents the WPE from correctly stopping the playback before restarting it for the next loop and the playback ends up paused forever: ``` webkitmediaplayer MediaPlayerPrivateGStreamer.cpp:1851:handleMessage:<video-1> EOS received but position {23823333333/1000000000 = 23.823333333} is still in the finite playable limits [{0/1 = 0}, {23828333333/1000000000 = 23.828333333}], ignoring it ``` Ignore early EOS only when not looping, otherwise unconditionally indicate the stream has ended. * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::handleMessage): Canonical link: https://commits.webkit.org/270593@main
https://bugs.webkit.org/show_bug.cgi?id=264670 Unreviewed. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/media-capabilities/encodingInfo.webrtc-expected.txt: * LayoutTests/platform/gtk/TestExpectations: * LayoutTests/platform/wpe/TestExpectations: Canonical link: https://commits.webkit.org/270594@main
https://bugs.webkit.org/show_bug.cgi?id=264563 Reviewed by Chris Dumez. Remove EnumTraits specializations for the BackgroundFetchFailureReason and BackgroundFetchResult enumerations. Instead, provide IPC serialization specification for the two enumerations in the WebCoreArgumentCoders serialization input file. * Source/WebCore/workers/service/background-fetch/BackgroundFetchFailureReason.h: * Source/WebCore/workers/service/background-fetch/BackgroundFetchResult.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/270595@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most significant part of this update is that upstream merged together TextureMapper and TextureMapperGL. As a result, qtwebkit needs to use a vendored version of TextureMapper.