Qt6 #21
Merged
Qt6 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many things are broken and/or disabled, but it may serve as a basis for a proper and complete update.
Signed-off-by: Aurélien Brooke <[email protected]>
Signed-off-by: Aurélien Brooke <[email protected]>
Signed-off-by: Aurélien Brooke <[email protected]>
Signed-off-by: Aurélien Brooke <[email protected]>
Signed-off-by: Aurélien Brooke <[email protected]>
Signed-off-by: Aurélien Brooke <[email protected]>
Signed-off-by: Aurélien Brooke <[email protected]>
…rce/WebKitLegacy/qt/tests
This seems somehow related to QPalette not being able to draw a gradient, for some reason.
Osyotr
reviewed
Jan 8, 2025
| @@ -333,7 +333,8 @@ String Pasteboard::readString(const String& type) | |||
| return data->text(); | |||
|
|
|||
| QByteArray rawData = data->data(mimeType); | |||
| QString stringData = QTextCodec::codecForName("UTF-16")->toUnicode(rawData); | |||
| auto toUtf16 = QStringDecoder(QStringDecoder::Utf8); | |||
There was a problem hiding this comment.
This looks wrong. rawData seems to be in UTF-16 already.
Not sure why the original code used QTextCodec in the first place, because QString can convert from UTF16 natively:
return QString::fromUtf16(reinterpret_cast<const char16_t *>(rawData.constData()), rawData.size());
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch qtwebkit over to support Qt6.
Does some of the things in qtwebkit#880 but many are yet to be done.