Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt6 GHA #22

Open
wants to merge 63 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
473a02a
fix deprecations in QLocale and QFlags
mnutt Jan 1, 2023
b887deb
QUrl::topLevelDomain() is deprecated, use private qTopLevelDomain() f…
mnutt Jan 1, 2023
77c19e8
qt6 deprecations around QNetworkRequest and QFontMetrics
mnutt Jan 1, 2023
89d30c4
more deprecations
mnutt Jan 2, 2023
23f7ddb
QRegion::rects() deprecated; use iterator instead
mnutt Jan 2, 2023
ba3b928
replace sprintf with qstring arg()s
mnutt Jan 2, 2023
95f0c4d
constant deprecations
mnutt Jan 2, 2023
754b2f9
use QGuiApplication::screens() to determine desktop size
mnutt Jan 2, 2023
c6c2145
lastResortFamily() is deprecated; use what they hardcoded: helvetica
mnutt Jan 2, 2023
4c01733
deprecations
mnutt Jan 2, 2023
728d0ec
Update QtWebkit to Qt 6
mnutt Jan 2, 2023
007b73c
Update to the new bincrafters URL in build-qtwebkit-conan.py
a12e Feb 20, 2022
b9a2d16
Remove dead "qtproject" conan repositories
a12e Feb 20, 2022
ddcfb68
Remove all "qtproject/stable" references
a12e Feb 20, 2022
65d5f36
Add Qt version 6.2.3 in Conan file
a12e Feb 20, 2022
6e15c34
Remove woff2 dependency
a12e Feb 20, 2022
e6dd187
Rename Qt5 to Qt6 in conan files
a12e Feb 20, 2022
c9c1880
Fix Qt 6 build with ENABLE_PRINT_SUPPORT
a12e Mar 27, 2022
d3ca4c6
qt6 no longer has bearermanagement
mnutt Jan 4, 2023
3afdaae
QStringRef deprecated in favor of QStringView
mnutt Jan 4, 2023
11b5b65
QURL::topLevelDomain() was removed; we can now use webkit's Registrab…
mnutt Jan 4, 2023
8c254fa
qt6 cmake target rcc
mnutt Jan 4, 2023
a53d817
cmake now seems to find OpenGL::GLX, so webkit's FindOpenGL should ch…
mnutt Jan 4, 2023
c6b064a
more qt deprecations
mnutt Jan 4, 2023
5efa1c5
remove remaining uses of foreach
mnutt Jan 4, 2023
aaa4096
Q_EMIT is a preprocessor directive now
mnutt Jan 4, 2023
87ec207
qt6 qevent updates
mnutt Jan 4, 2023
ec0a53e
remove dependency on Qt6Core5Compat
mnutt Jan 6, 2023
f02ba57
implement stubbed RunLoop::TimerBase::secondsUntilFire
mnutt Jan 7, 2023
d058e04
qt tests moved to root-level tests; need to eventually get rid of Sou…
mnutt Jan 7, 2023
e480f32
make StateMachine optional now that it has moved out of qt core
mnutt Jan 7, 2023
962beed
fix compilation errors in tests (they do not pass yet)
mnutt Jan 7, 2023
e3b7365
allow for building without QtOpenGLWidgets
mnutt Jan 8, 2023
1eef4f5
Fix FileSystemQt method signature
mnutt Jan 9, 2023
3708e31
ImageGStreamer qt method signature
mnutt Jan 9, 2023
723624c
Merge branch 'qt6-from-a12e' into merge-upstream-2023-04-11-qt6
mnutt Jun 20, 2023
dfd9a42
Merge branch 'merge-upstream-2023-04-11-qt6' into merge-upstream-2023…
mnutt Jul 12, 2023
19dbe62
ensure explicit String(Vector<UChar, 64>)
mnutt Jul 15, 2023
39d96f4
Merge branch 'merge-upstream-2023-06-21-qt6' into merge-upstream-2023…
mnutt Nov 19, 2023
4d494b0
resurrect RenderThemeQStyle; it is no longer page-dependent
mnutt Nov 28, 2023
de93ad1
misc warnings fixes
mnutt Nov 28, 2023
894578c
use style.effectiveAppearance() to convert Auto to real appearance
mnutt Nov 28, 2023
e4bbd34
fix crash due to styleResolver change
mnutt Nov 28, 2023
4648628
slightly more attractive styling for mobile theme
mnutt Nov 28, 2023
68f7f90
remove unused include from styleresolver removal
mnutt Nov 28, 2023
f1200e6
QtTestBrowser: resolve black location bar during loading
mnutt Nov 28, 2023
efaa509
revert gstreamer version, to support focal for a short while longer
mnutt Dec 1, 2023
9fbea79
more fallout from TEXTURE_MAPPER and TEXTURE_MAPPER_GL merge
mnutt Dec 1, 2023
eaa7131
fix include for WebAudioSourceProvider
mnutt Dec 1, 2023
47c76ef
ensure qt6 qnam does not auto follow redirects
mnutt Dec 6, 2023
617563f
QStringView should not be passed as a const ref
mnutt Dec 6, 2023
5cf6322
remove extra allocation in QWebFrameAdapter
mnutt Dec 7, 2023
bc5d7d3
re-add (now non-functional) plugin APIs, to keep compatibility with q…
mnutt Dec 17, 2023
902cfc3
Merge branch 'plugin-stubs-readded-qt6' into merge-upstream-2023-11-1…
mnutt Dec 18, 2023
97aeaeb
Merge branch 'merge-upstream-2023-12-18' into merge-upstream-2023-12-…
mnutt Dec 20, 2023
0414388
enable new layer based svg engine
mnutt Dec 22, 2023
84f7d57
switch qt build version to qt6
mnutt Jan 12, 2024
ff7afd1
build on all pushes for now
mnutt Jan 12, 2024
1b02bfc
qt6 deps
mnutt Jan 12, 2024
de91f03
try declaring some qt classes
mnutt Jan 12, 2024
a9606c2
qt didn't have qlatin1stringview prior to 6.4
mnutt Jan 12, 2024
1627146
need size() to be compatible with QLatin1String
mnutt Jan 12, 2024
ee690e4
conditional for qt < 6.3 QMutableEventPoint
mnutt Jan 13, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/build_cmake.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ name: CMake Build Matrix
on:
push:
branches:
- master
- '*'

pull_request:
branches:
- master

env:
QT_VERSION: 5.15.1
QT_VERSION: 6.6.1
CCACHE_VERSION: 3.7.7
CACHE_PARTITION: dev
HOST_N_CORES: 2
Expand Down Expand Up @@ -74,7 +74,7 @@ jobs:
env:
TOOLCHAIN: "win64_msvc2019_64"
DIR: "msvc2019_64"
shell: bash --noprofile --norc -eo pipefail -x {0}
shell: bash --noprofile --norc -eo pipefail -x {0}
run: |
py -m pip install -r Tools/qt/qt-downloader-requirements.txt
QT_INSTALL_DIR="/c/Qt"
Expand All @@ -89,7 +89,7 @@ jobs:
id: qt_mac
if: runner.os == 'macOS'
shell: bash --noprofile --norc -eo pipefail -x {0}
env:
env:
TOOLCHAIN: "clang_64"
run: |
pip3 install -r Tools/qt/qt-downloader-requirements.txt
Expand Down Expand Up @@ -138,7 +138,7 @@ jobs:
if: runner.os == 'Linux'
run: |
sudo apt-get update && sudo apt-get install \
ninja-build build-essential bison flex gperf libfontconfig1-dev libgl1-mesa-dev libglib2.0-dev libgstreamer-plugins-base1.0-dev libgstreamer1.0-dev libhyphen-dev libicu-dev libjpeg-dev libpng-dev libqt5opengl5-dev libqt5sensors5-dev libqt5webchannel5-dev libsqlite3-dev libwebp-dev libwoff-dev libxcomposite-dev libxml2-dev libxrender-dev libxslt1-dev mesa-common-dev pkg-config python3 qtbase5-private-dev qtdeclarative5-private-dev qtpositioning5-dev ruby libqt5sql5-sqlite qtbase5-doc-html qttools5-dev-tools \
ninja-build build-essential bison flex gperf libfontconfig1-dev libgl1-mesa-dev libglib2.0-dev libgstreamer-plugins-base1.0-dev libgstreamer1.0-dev libhyphen-dev libicu-dev libjpeg-dev libpng-dev libqt6opengl6-dev libqt6sensors6-dev libqt6webchannel6-dev libsqlite3-dev libwebp-dev libwoff-dev libxcomposite-dev libxml2-dev libxrender-dev libxslt1-dev mesa-common-dev pkg-config python3 qt6-base-dev qt6-base-private-dev qt6-declarative-private-dev qt6-positioning-dev ruby libqt6sql6-sqlite qt6-base-dev-tools \
libtasn1-6-dev libgcrypt20-dev libunwind-dev libharfbuzz-dev

- name: CMake version
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/draft_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
description: "Coin build number, e.g. 1600955993"
required: true
qt_version:
description: "Qt version used for building artifacts, e.g. 5.15.1"
description: "Qt version used for building artifacts, e.g. 6.6.1"
required: true
tag_name:
description: "Tag name, e.g. qtwebkit-5.212.0-alpha5"
Expand Down
4 changes: 2 additions & 2 deletions Source/JavaScriptCore/PlatformQt.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ list(APPEND JavaScriptCore_PRIVATE_FRAMEWORK_HEADERS
)

list(APPEND JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES
${Qt5Core_INCLUDE_DIRS}
${Qt6Core_INCLUDE_DIRS}
)

list(APPEND JavaScriptCore_LIBRARIES
${Qt5Core_LIBRARIES}
${Qt6Core_LIBRARIES}
)

if (QT_STATIC_BUILD)
Expand Down
100 changes: 50 additions & 50 deletions Source/PlatformQt.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -132,35 +132,35 @@ endmacro ()
set(_package_footer_template "
####### Expanded from QTWEBKIT_PACKAGE_FOOTER variable #######

set(Qt5@MODULE_NAME@_LIBRARIES Qt5::@MODULE_NAME@)
set(Qt5@MODULE_NAME@_VERSION_STRING \${Qt5@MODULE_NAME@_VERSION})
set(Qt5@MODULE_NAME@_EXECUTABLE_COMPILE_FLAGS \"\")
set(Qt5@MODULE_NAME@_PRIVATE_INCLUDE_DIRS \"\") # FIXME: Support private headers

get_target_property(Qt5@MODULE_NAME@_INCLUDE_DIRS Qt5::@FULL_MODULE_NAME@ INTERFACE_INCLUDE_DIRECTORIES)
get_target_property(Qt5@MODULE_NAME@_COMPILE_DEFINITIONS Qt5::@FULL_MODULE_NAME@ INTERFACE_COMPILE_DEFINITIONS)

foreach (_module_dep \${_Qt5@MODULE_NAME@_MODULE_DEPENDENCIES})
list(APPEND Qt5@MODULE_NAME@_INCLUDE_DIRS \${Qt5\${_module_dep}_INCLUDE_DIRS})
list(APPEND Qt5@MODULE_NAME@_PRIVATE_INCLUDE_DIRS \${Qt5\${_module_dep}_PRIVATE_INCLUDE_DIRS})
list(APPEND Qt5@MODULE_NAME@_DEFINITIONS \${Qt5\${_module_dep}_DEFINITIONS})
list(APPEND Qt5@MODULE_NAME@_COMPILE_DEFINITIONS \${Qt5\${_module_dep}_COMPILE_DEFINITIONS})
list(APPEND Qt5@MODULE_NAME@_EXECUTABLE_COMPILE_FLAGS \${Qt5\${_module_dep}_EXECUTABLE_COMPILE_FLAGS})
set(Qt6@MODULE_NAME@_LIBRARIES Qt6::@MODULE_NAME@)
set(Qt6@MODULE_NAME@_VERSION_STRING \${Qt6@MODULE_NAME@_VERSION})
set(Qt6@MODULE_NAME@_EXECUTABLE_COMPILE_FLAGS \"\")
set(Qt6@MODULE_NAME@_PRIVATE_INCLUDE_DIRS \"\") # FIXME: Support private headers

get_target_property(Qt6@MODULE_NAME@_INCLUDE_DIRS Qt6::@FULL_MODULE_NAME@ INTERFACE_INCLUDE_DIRECTORIES)
get_target_property(Qt6@MODULE_NAME@_COMPILE_DEFINITIONS Qt6::@FULL_MODULE_NAME@ INTERFACE_COMPILE_DEFINITIONS)

foreach (_module_dep \${_Qt6@MODULE_NAME@_MODULE_DEPENDENCIES})
list(APPEND Qt6@MODULE_NAME@_INCLUDE_DIRS \${Qt6\${_module_dep}_INCLUDE_DIRS})
list(APPEND Qt6@MODULE_NAME@_PRIVATE_INCLUDE_DIRS \${Qt6\${_module_dep}_PRIVATE_INCLUDE_DIRS})
list(APPEND Qt6@MODULE_NAME@_DEFINITIONS \${Qt6\${_module_dep}_DEFINITIONS})
list(APPEND Qt6@MODULE_NAME@_COMPILE_DEFINITIONS \${Qt6\${_module_dep}_COMPILE_DEFINITIONS})
list(APPEND Qt6@MODULE_NAME@_EXECUTABLE_COMPILE_FLAGS \${Qt6\${_module_dep}_EXECUTABLE_COMPILE_FLAGS})
endforeach ()
list(REMOVE_DUPLICATES Qt5@MODULE_NAME@_INCLUDE_DIRS)
list(REMOVE_DUPLICATES Qt5@MODULE_NAME@_PRIVATE_INCLUDE_DIRS)
list(REMOVE_DUPLICATES Qt5@MODULE_NAME@_DEFINITIONS)
list(REMOVE_DUPLICATES Qt5@MODULE_NAME@_COMPILE_DEFINITIONS)
list(REMOVE_DUPLICATES Qt5@MODULE_NAME@_EXECUTABLE_COMPILE_FLAGS)
list(REMOVE_DUPLICATES Qt6@MODULE_NAME@_INCLUDE_DIRS)
list(REMOVE_DUPLICATES Qt6@MODULE_NAME@_PRIVATE_INCLUDE_DIRS)
list(REMOVE_DUPLICATES Qt6@MODULE_NAME@_DEFINITIONS)
list(REMOVE_DUPLICATES Qt6@MODULE_NAME@_COMPILE_DEFINITIONS)
list(REMOVE_DUPLICATES Qt6@MODULE_NAME@_EXECUTABLE_COMPILE_FLAGS)

# Fixup order of configurations to match behavior of other Qt modules
# See also https://bugreports.qt.io/browse/QTBUG-29186
get_target_property(_configurations Qt5::@FULL_MODULE_NAME@ IMPORTED_CONFIGURATIONS)
get_target_property(_configurations Qt6::@FULL_MODULE_NAME@ IMPORTED_CONFIGURATIONS)
list(FIND _configurations RELEASE _index)
if (\${_index} GREATER -1)
list(REMOVE_AT _configurations \${_index})
list(INSERT _configurations 0 RELEASE)
set_property(TARGET Qt5::@FULL_MODULE_NAME@ PROPERTY IMPORTED_CONFIGURATIONS \"\${_configurations}\")
set_property(TARGET Qt6::@FULL_MODULE_NAME@ PROPERTY IMPORTED_CONFIGURATIONS \"\${_configurations}\")
endif ()
unset(_configurations)
unset(_index)
Expand All @@ -169,73 +169,73 @@ unset(_index)
set(MODULE_NAME WebKit)
set(FULL_MODULE_NAME WebKitLegacy)
string(CONFIGURE ${_package_footer_template} QTWEBKIT_PACKAGE_FOOTER @ONLY)
ecm_configure_package_config_file("${CMAKE_CURRENT_SOURCE_DIR}/Qt5WebKitConfig.cmake.in"
"${CMAKE_CURRENT_BINARY_DIR}/Qt5WebKitConfig.cmake"
INSTALL_DESTINATION "${KDE_INSTALL_CMAKEPACKAGEDIR}/Qt5WebKit"
ecm_configure_package_config_file("${CMAKE_CURRENT_SOURCE_DIR}/Qt6WebKitConfig.cmake.in"
"${CMAKE_CURRENT_BINARY_DIR}/Qt6WebKitConfig.cmake"
INSTALL_DESTINATION "${KDE_INSTALL_CMAKEPACKAGEDIR}/Qt6WebKit"
)

set(MODULE_NAME WebKitWidgets)
set(FULL_MODULE_NAME WebKitWidgets)
string(CONFIGURE ${_package_footer_template} QTWEBKIT_PACKAGE_FOOTER @ONLY)
ecm_configure_package_config_file("${CMAKE_CURRENT_SOURCE_DIR}/Qt5WebKitWidgetsConfig.cmake.in"
"${CMAKE_CURRENT_BINARY_DIR}/Qt5WebKitWidgetsConfig.cmake"
INSTALL_DESTINATION "${KDE_INSTALL_CMAKEPACKAGEDIR}/Qt5WebKitWidgets"
ecm_configure_package_config_file("${CMAKE_CURRENT_SOURCE_DIR}/Qt6WebKitWidgetsConfig.cmake.in"
"${CMAKE_CURRENT_BINARY_DIR}/Qt6WebKitWidgetsConfig.cmake"
INSTALL_DESTINATION "${KDE_INSTALL_CMAKEPACKAGEDIR}/Qt6WebKitWidgets"
)

unset(MODULE_NAME)
unset(FULL_MODULE_NAME)
unset(QTWEBKIT_PACKAGE_FOOTER)

write_basic_package_version_file("${CMAKE_CURRENT_BINARY_DIR}/Qt5WebKitConfigVersion.cmake"
write_basic_package_version_file("${CMAKE_CURRENT_BINARY_DIR}/Qt6WebKitConfigVersion.cmake"
VERSION ${PROJECT_VERSION}
COMPATIBILITY AnyNewerVersion)
write_basic_package_version_file("${CMAKE_CURRENT_BINARY_DIR}/Qt5WebKitWidgetsConfigVersion.cmake"
write_basic_package_version_file("${CMAKE_CURRENT_BINARY_DIR}/Qt6WebKitWidgetsConfigVersion.cmake"
VERSION ${PROJECT_VERSION}
COMPATIBILITY AnyNewerVersion)

install(FILES
"${CMAKE_CURRENT_BINARY_DIR}/Qt5WebKitConfig.cmake"
"${CMAKE_CURRENT_BINARY_DIR}/Qt5WebKitConfigVersion.cmake"
DESTINATION "${KDE_INSTALL_CMAKEPACKAGEDIR}/Qt5WebKit"
"${CMAKE_CURRENT_BINARY_DIR}/Qt6WebKitConfig.cmake"
"${CMAKE_CURRENT_BINARY_DIR}/Qt6WebKitConfigVersion.cmake"
DESTINATION "${KDE_INSTALL_CMAKEPACKAGEDIR}/Qt6WebKit"
COMPONENT Data
)
install(FILES
"${CMAKE_CURRENT_BINARY_DIR}/Qt5WebKitWidgetsConfig.cmake"
"${CMAKE_CURRENT_BINARY_DIR}/Qt5WebKitWidgetsConfigVersion.cmake"
DESTINATION "${KDE_INSTALL_CMAKEPACKAGEDIR}/Qt5WebKitWidgets"
"${CMAKE_CURRENT_BINARY_DIR}/Qt6WebKitWidgetsConfig.cmake"
"${CMAKE_CURRENT_BINARY_DIR}/Qt6WebKitWidgetsConfigVersion.cmake"
DESTINATION "${KDE_INSTALL_CMAKEPACKAGEDIR}/Qt6WebKitWidgets"
COMPONENT Data
)

# We need to install separate config files for debug and release, so use "Code" component
install(EXPORT WebKitTargets
FILE WebKitTargets.cmake
NAMESPACE Qt5::
DESTINATION "${KDE_INSTALL_CMAKEPACKAGEDIR}/Qt5WebKit"
NAMESPACE Qt6::
DESTINATION "${KDE_INSTALL_CMAKEPACKAGEDIR}/Qt6WebKit"
COMPONENT Code
)
install(EXPORT Qt5WebKitWidgetsTargets
FILE Qt5WebKitWidgetsTargets.cmake
NAMESPACE Qt5::
DESTINATION "${KDE_INSTALL_CMAKEPACKAGEDIR}/Qt5WebKitWidgets"
install(EXPORT Qt6WebKitWidgetsTargets
FILE Qt6WebKitWidgetsTargets.cmake
NAMESPACE Qt6::
DESTINATION "${KDE_INSTALL_CMAKEPACKAGEDIR}/Qt6WebKitWidgets"
COMPONENT Code
)

# Documentation

if (NOT TARGET Qt5::qdoc)
add_executable(Qt5::qdoc IMPORTED)
if (NOT TARGET Qt6::qdoc)
add_executable(Qt6::qdoc IMPORTED)
query_qmake(QDOC_EXECUTABLE QT_INSTALL_BINS)
set(QDOC_EXECUTABLE "${QDOC_EXECUTABLE}/qdoc")
set_target_properties(Qt5::qdoc PROPERTIES
set_target_properties(Qt6::qdoc PROPERTIES
IMPORTED_LOCATION ${QDOC_EXECUTABLE}
)
endif ()

if (NOT TARGET Qt5::qhelpgenerator)
add_executable(Qt5::qhelpgenerator IMPORTED)
if (NOT TARGET Qt6::qhelpgenerator)
add_executable(Qt6::qhelpgenerator IMPORTED)
query_qmake(QHELPGENERATOR_EXECUTABLE QT_INSTALL_BINS)
set(QHELPGENERATOR_EXECUTABLE "${QHELPGENERATOR_EXECUTABLE}/qhelpgenerator")
set_target_properties(Qt5::qhelpgenerator PROPERTIES
set_target_properties(Qt6::qhelpgenerator PROPERTIES
IMPORTED_LOCATION ${QHELPGENERATOR_EXECUTABLE}
)
endif ()
Expand Down Expand Up @@ -272,13 +272,13 @@ set(EXPORT_VARS_COMMANDS

add_custom_target(prepare_docs ${NEED_ALL}
${EXPORT_VARS_COMMANDS}
COMMAND Qt5::qdoc ${QDOC_CONFIG} -prepare -outputdir "${DOC_OUTPUT_DIR}/qtwebkit" -installdir ${DOC_INSTALL_DIR} -indexdir ${QT_INSTALL_DOCS} -no-link-errors
COMMAND Qt6::qdoc ${QDOC_CONFIG} -prepare -outputdir "${DOC_OUTPUT_DIR}/qtwebkit" -installdir ${DOC_INSTALL_DIR} -indexdir ${QT_INSTALL_DOCS} -no-link-errors
VERBATIM
)

add_custom_target(generate_docs ${NEED_ALL}
${EXPORT_VARS_COMMANDS}
COMMAND Qt5::qdoc ${QDOC_CONFIG} -generate -outputdir "${DOC_OUTPUT_DIR}/qtwebkit" -installdir ${DOC_INSTALL_DIR} -indexdir ${QT_INSTALL_DOCS}
COMMAND Qt6::qdoc ${QDOC_CONFIG} -generate -outputdir "${DOC_OUTPUT_DIR}/qtwebkit" -installdir ${DOC_INSTALL_DIR} -indexdir ${QT_INSTALL_DOCS}
VERBATIM
)
add_dependencies(generate_docs prepare_docs)
Expand All @@ -287,7 +287,7 @@ add_custom_target(html_docs)
add_dependencies(html_docs generate_docs)

add_custom_target(qch_docs ${NEED_ALL}
COMMAND Qt5::qhelpgenerator "${DOC_OUTPUT_DIR}/qtwebkit/qtwebkit.qhp" -o "${DOC_OUTPUT_DIR}/qtwebkit.qch"
COMMAND Qt6::qhelpgenerator "${DOC_OUTPUT_DIR}/qtwebkit/qtwebkit.qhp" -o "${DOC_OUTPUT_DIR}/qtwebkit.qch"
VERBATIM
)
add_dependencies(qch_docs html_docs)
Expand Down
13 changes: 0 additions & 13 deletions Source/Qt5WebKitConfig.cmake.in

This file was deleted.

12 changes: 0 additions & 12 deletions Source/Qt5WebKitWidgetsConfig.cmake.in

This file was deleted.

13 changes: 13 additions & 0 deletions Source/Qt6WebKitConfig.cmake.in
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
@PACKAGE_INIT@
@QTWEBKIT_PACKAGE_INIT@

find_dependency_with_major_and_minor(Qt6Core @Qt6_VERSION_MAJOR@ @Qt6_VERSION_MINOR@)
find_dependency_with_major_and_minor(Qt6Gui @Qt6_VERSION_MAJOR@ @Qt6_VERSION_MINOR@)
find_dependency_with_major_and_minor(Qt6Network @Qt6_VERSION_MAJOR@ @Qt6_VERSION_MINOR@)

include("${CMAKE_CURRENT_LIST_DIR}/WebKitTargets.cmake")

set(_Qt6WebKit_MODULE_DEPENDENCIES "Gui;Network;Core")
set(Qt6WebKit_DEFINITIONS -DQT_WEBKIT_LIB)

@QTWEBKIT_PACKAGE_FOOTER@
12 changes: 12 additions & 0 deletions Source/Qt6WebKitWidgetsConfig.cmake.in
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
@PACKAGE_INIT@
@QTWEBKIT_PACKAGE_INIT@

find_dependency(Qt6WebKit @PROJECT_VERSION_STRING@ EXACT)
find_dependency_with_major_and_minor(Qt6Widgets @Qt6_VERSION_MAJOR@ @Qt6_VERSION_MINOR@)

include("${CMAKE_CURRENT_LIST_DIR}/Qt6WebKitWidgetsTargets.cmake")

set(_Qt6WebKitWidgets_MODULE_DEPENDENCIES "WebKit;Widgets;Gui;Network;Core")
set(Qt6WebKitWidgets_DEFINITIONS -DQT_WEBKITWIDGETS_LIB)

@QTWEBKIT_PACKAGE_FOOTER@
4 changes: 3 additions & 1 deletion Source/WTF/wtf/FileSystem.h
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,9 @@ const PlatformFileHandle invalidPlatformFileHandle = -1;
#endif

// PlatformFileID
#if OS(WINDOWS)
#if USE(GLIB) && !OS(WINDOWS) && !PLATFORM(QT)
typedef CString PlatformFileID;
#elif OS(WINDOWS)
typedef FILE_ID_128 PlatformFileID;
#else
typedef ino_t PlatformFileID;
Expand Down
2 changes: 1 addition & 1 deletion Source/WTF/wtf/Platform.h
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@
#endif // QT_VERSION >= QT_VERSION_CHECK(5,8,0)

#include <QtNetwork/qtnetwork-config.h>
#if !QT_CONFIG(bearermanagement)
#if QT_VERSION >= QT_VERSION_CHECK(6,0,0) || !QT_CONFIG(bearermanagement)
#ifndef QT_NO_BEARERMANAGEMENT
#define QT_NO_BEARERMANAGEMENT
#endif // QT_NO_BEARERMANAGEMENT
Expand Down
4 changes: 2 additions & 2 deletions Source/WTF/wtf/PlatformQt.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,11 @@ if (USE_MACH_PORTS)
endif()

list(APPEND WTF_SYSTEM_INCLUDE_DIRECTORIES
${Qt5Core_INCLUDE_DIRS}
${Qt6Core_INCLUDE_DIRS}
)

list(APPEND WTF_LIBRARIES
${Qt5Core_LIBRARIES}
${Qt6Core_LIBRARIES}
Threads::Threads
)

Expand Down
6 changes: 6 additions & 0 deletions Source/WTF/wtf/qt/RunLoopQt.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,12 @@ bool RunLoop::TimerBase::isActive() const
return m_isActive;
}

Seconds RunLoop::TimerBase::secondsUntilFire() const
{
// FIXME: implement for WebKit
return 0_s;
}

#include "RunLoopQt.moc"

} // namespace WTF
4 changes: 2 additions & 2 deletions Source/WTF/wtf/text/AtomString.h
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ class AtomString final {

#if PLATFORM(QT)
WTF_EXPORT_PRIVATE AtomString(const QString&);
WTF_EXPORT_PRIVATE AtomString(const QStringRef&);
WTF_EXPORT_PRIVATE AtomString(QStringView);
#endif

#if OS(WINDOWS)
Expand Down Expand Up @@ -160,7 +160,7 @@ static_assert(sizeof(AtomString) == sizeof(String), "AtomString and String must

inline bool operator==(const AtomString& a, const AtomString& b) { return a.impl() == b.impl(); }
inline bool operator==(const AtomString& a, ASCIILiteral b) { return WTF::equal(a.impl(), b); }
inline bool operator==(const AtomString& a, const Vector<UChar>& b) { return a.impl() && equal(a.impl(), b.data(), b.size()); }
inline bool operator==(const AtomString& a, const Vector<UChar>& b) { return a.impl() && equal(a.impl(), b.data(), b.size()); }
inline bool operator==(const AtomString& a, const String& b) { return equal(a.impl(), b.impl()); }
inline bool operator==(const String& a, const AtomString& b) { return equal(a.impl(), b.impl()); }
inline bool operator==(const Vector<UChar>& a, const AtomString& b) { return b == a; }
Expand Down
12 changes: 11 additions & 1 deletion Source/WTF/wtf/text/WTFString.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@
#if PLATFORM(QT)
QT_BEGIN_NAMESPACE
class QString;
class QStringView;
class QLatin1String;
class QByteArrayView;
QT_END_NAMESPACE
#endif

Expand Down Expand Up @@ -260,8 +263,15 @@ class String final {

#if PLATFORM(QT)
WTF_EXPORT_PRIVATE String(const QString&);
WTF_EXPORT_PRIVATE String(const QStringRef&);
WTF_EXPORT_PRIVATE String(QLatin1String);
WTF_EXPORT_PRIVATE String(QStringView);
WTF_EXPORT_PRIVATE String(QByteArrayView);
WTF_EXPORT_PRIVATE operator QString() const;

// String(QStringView) makes for an ambiguous constructor, so we need to make these explicit
ALWAYS_INLINE String(Vector<UChar, 64> characters) : String(characters.data(), characters.size()) {}
ALWAYS_INLINE String(Vector<UChar, 32> characters) : String(characters.data(), characters.size()) {}
ALWAYS_INLINE String(Vector<UChar> characters) : String(characters.data(), characters.size()) {}
#endif

#if OS(WINDOWS)
Expand Down
Loading
Loading