Skip to content

Commit

Permalink
Remove 'upload_saved_list_rest' workaround that stripped query parame…
Browse files Browse the repository at this point in the history
…ters from URL (#675)
  • Loading branch information
shaunagm authored Apr 28, 2022
1 parent 3886327 commit 41ebf4a
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions parsons/ngpvan/saved_lists.py
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ def upload_saved_list_rest(self, tbl, url_type, folder_id, list_name,
rando = str(uuid.uuid1())
file_name = rando + '.csv'
url = cloud_storage.post_file(tbl, url_type, file_path=rando + '.zip', **url_kwargs)
url_for_van = url.split('?')[0] # hack around github.com/move-coop/parsons/issues/513
logger.info(f'Table uploaded to {url_type}.')

# VAN errors for this method are not particularly useful or helpful. For that reason, we
Expand All @@ -140,7 +139,7 @@ def upload_saved_list_rest(self, tbl, url_type, folder_id, list_name,
"fileName": file_name,
"hasHeader": header,
"hasQuotes": quotes,
"sourceUrl": url_for_van
"sourceUrl": url
},
"actions": [
{"actionType": "LoadSavedListFile",
Expand Down

0 comments on commit 41ebf4a

Please sign in to comment.