This repository has been archived by the owner on May 4, 2024. It is now read-only.
Revert "[account-address] Input and output with a 0x for hex output (… #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ove-language#7)" This reverts commit ba7c064.
|
@tnowacki I'd like to push this through, as the previous PR needs more testing, and has caused other issues as a result. I believe the serialization changes I made are at fault. I'll come back to fix all of them together |
tnowacki
approved these changes
Apr 20, 2022
|
/land ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…#7)"
This reverts commit ba7c064.
This change causes issues with module publishing and transactions, as it doesn't properly convert all hex versions. I'll fix it in this PR #54 but for now I need to revert it
@tnowacki