-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decorate MoveItConfigs with dataclass #1308
Decorate MoveItConfigs with dataclass #1308
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1308 +/- ##
==========================================
- Coverage 61.48% 61.46% -0.01%
==========================================
Files 274 274
Lines 24940 24940
==========================================
- Hits 15332 15328 -4
- Misses 9608 9612 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much cleaner!
8c88efa
to
28f67ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very nice! I assume this is fully compatible with the old version?
This uses a feature from Python 3.10, so it only work with Jammy |
28f67ec
to
43a3c3f
Compare
(cherry picked from commit 4502659)
(cherry picked from commit 4502659) Co-authored-by: Jafar <[email protected]>
Description
Fix: #1292 (comment), this reduces the duplication and make the class easier to read
Checklist