-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.10.0 (Rolling, Jazzy) - DON'T MERGE #2867
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Only source generate_parameter_library for Humble and Iron * Depend on moveit2.repos for Jazzy, Rolling * Switch GitHub orgs from ros-planning to "moveit"
This reverts commit 55df0bc. The deprecated constructor was being used in the same file for the exact use case of enabling namespaces that are not specified by the parameter. There is no replacement for supporting a dynamic server lookup, however the parameter logic could still use simplification.
--------- Co-authored-by: Robert Haschke <[email protected]>
- AnalyzeTemporaryDtors was removed - disable performance-enum-size
10 tasks
rhaschke
reviewed
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I have a few remarks only:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopen of #2846 - don't merge, only fast forward
The tutorials are still expected to fail unfortunately. We will have to fix the kinova runtime dependency for that. All the other jobs should succeed.