Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.10.0 (Rolling, Jazzy) - DON'T MERGE #2867

Merged
merged 13 commits into from
Jun 14, 2024
Merged

Conversation

henningkayser
Copy link
Member

@henningkayser henningkayser commented Jun 13, 2024

Reopen of #2846 - don't merge, only fast forward

The tutorials are still expected to fail unfortunately. We will have to fix the kinova runtime dependency for that. All the other jobs should succeed.

henningkayser and others added 12 commits June 13, 2024 17:30
* Only source generate_parameter_library for Humble and Iron
* Depend on moveit2.repos for Jazzy, Rolling
* Switch GitHub orgs from ros-planning to "moveit"
This reverts commit 55df0bc.

The deprecated constructor was being used in the same file
for the exact use case of enabling namespaces that are not
specified by the parameter. There is no replacement for
supporting a dynamic server lookup, however the parameter
logic could still use simplification.
---------

Co-authored-by: Robert Haschke <[email protected]>
- AnalyzeTemporaryDtors was removed
- disable performance-enum-size
@henningkayser henningkayser requested a review from sjahr June 13, 2024 16:16
@henningkayser henningkayser mentioned this pull request Jun 13, 2024
10 tasks
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have a few remarks only:

.github/workflows/ci.yaml Show resolved Hide resolved
moveit2.repos Show resolved Hide resolved
@henningkayser henningkayser merged commit c05b013 into main Jun 14, 2024
15 of 18 checks passed
@henningkayser henningkayser deleted the release/2.10.0 branch June 14, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants