Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix link to recently-moved MoveIt for ROS 1 tutorials #901

Merged
merged 7 commits into from
Jun 7, 2024

Conversation

v4hn
Copy link
Contributor

@v4hn v4hn commented May 2, 2024

Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good starting point. But there are many more references to the old ros-planning org.
I think a PR should address all of them.

v4hn added 3 commits May 3, 2024 12:16
fgrep -rl ros-planning/ | xargs -n1 sed -i 's@ros-planning/@moveit/@g'
fgrep -rl 'ros-planning.' | xargs -n1 sed -i 's@ros-planning\.@moveit.@g'
@v4hn
Copy link
Contributor Author

v4hn commented May 3, 2024

My immediate concern was to get the MoveIt ROS one reference back working for users, not to fix the migration for the whole repository, with CI broken for different unrelated reasons at the moment.

But fair enough. I went through the repo with a few seds and changed all links and references.

One thing that popped up is that the github container registry is not migrated (yet?), e.g., ghcr.io/ros-planning/moveit2_tutorials. @henningkayser
I added the last commit to change those links for reference here, but it should not be merged yet.
Feel free to just drop that commit again if you are ok with merging the rest.

Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

index.rst Outdated Show resolved Hide resolved
@henningkayser
Copy link
Member

CI is currently failing because of ros2_kortex, which needs Kinovarobotics/ros2_kortex#159. I'll push a branch to generate new docker images, the registry is working as intended.

@henningkayser henningkayser merged commit 99b4203 into moveit:main Jun 7, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants