Temporarily fix issues with execution of pick+place demo #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like ROS2 uses a more relaxed goal constraint threshold than ROS1. For this reason, all end states reached by Connect solutions of pick+place demo are rejected. This commit relaxes the max_distance threshold of Connect as well.
|
I've opened a PR to port the necessary change to moveit2. Once that is in, you don't need to revert that commit anymore I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect stage: Relax validity check of reached end state
Looks like ROS2 uses a more relaxed goal constraint threshold than ROS1.
For this reason, all end states reached by Connect solutions of pick+place demo
are rejected. This commit relaxes the max_distance threshold of Connect as well.
MoveIt2 maintainers should check MoveIt2's goal constraint threshold and use a similar value in Connect stage.
Fixes ros2 branch was cleaned up and force-pushed #540 (comment)
Revert "Fix generation of Solution msg: consider backward operation"
This reverts commit 4aac679, because MoveIt2 is missing a port of PSM: keep references to scene_ valid upon receiving full scenes moveit#3538.
Fixes MTC Task Execution Failure - Moveit2 Pick n Place MTC demo moveit2_tutorials#881