Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libs/movex-react] Add spec for useMovex hook #132

Merged
merged 4 commits into from
Oct 20, 2023

Conversation

Arol15
Copy link
Contributor

@Arol15 Arol15 commented Oct 14, 2023

Linked Issue

#104

Description

  • Added spec and hooks folder to the movex-react;
  • Added a spec for useMovex hook;

Methodology

  • used renderHook from testing-library/react to test custom hooks;

Proof

Screenshot 2023-10-13 at 8 18 54 PM

Code of Conduct

By submitting this pull request, you agree to follow our Code of Conduct

@Arol15 Arol15 marked this pull request as ready for review October 14, 2023 00:22
Copy link
Contributor

@GabrielCTroia GabrielCTroia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Arol15, this looks good, but I would like a test where it is connected and the context returns values as well ideally!

Let me know if you need my help with anything! 🙏

Copy link
Contributor

@GabrielCTroia GabrielCTroia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this for now

@GabrielCTroia
Copy link
Contributor

Hey @Arol15 this is ready to merge, one last thing – can you please sign your commits as described here https://docs.github.com/articles/about-gpg/

@GabrielCTroia GabrielCTroia merged commit 118f362 into movesthatmatter:main Oct 20, 2023
2 checks passed
@GabrielCTroia GabrielCTroia added good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest hacktoberfest-accepted labels Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants