Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "[project] Duplicate the libs/movex/Readme.md at root #137" #156

Closed
wants to merge 9 commits into from

Conversation

jude-san
Copy link
Contributor

No description provided.

@GabrielCTroia
Copy link
Contributor

Hey @jude-san thank you for your PR. It seems like the CI jobs are failing with this error
Screenshot 2023-10-16 at 1 35 09 PM

Please see this answer https://stackoverflow.com/a/18419800/2093626 on how to fix it. Since the initial Readme was a symlink that needs to be reverted back to regular file!

Let me know if you need any help with it! 🙏

@jude-san
Copy link
Contributor Author

Hey @jude-san thank you for your PR. It seems like the CI jobs are failing with this error Screenshot 2023-10-16 at 1 35 09 PM

Please see this answer https://stackoverflow.com/a/18419800/2093626 on how to fix it. Since the initial Readme was a symlink that needs to be reverted back to regular file!

Let me know if you need any help with it! 🙏

Noted, thanks for the feedback.

@jude-san
Copy link
Contributor Author

HI @GabrielCTroia I need your help with these commits a17c3cb, 54963f2, and 3a56879. I pushed it before I verified my account using gpg keys.

@GabrielCTroia
Copy link
Contributor

GabrielCTroia commented Oct 20, 2023

Hey @jude-san, the way you can verify those commits is to rebase your branch now on top of master, just so the commits get signed, now that gpg is setup. Then you can force push the branch again.

See this answer https://stackoverflow.com/a/15667644/2093626, and I would do something like git rebase --signoff 8e49387

Let me know if that helps! 🙌

@jude-san
Copy link
Contributor Author

HI @GabrielCTroia I need your help with these commits a17c3cb, 54963f2, and 3a56879. I pushed it before I verified my account using gpg keys.

HI @GabrielCTroia is it possible to close this PR and start over?, since my commits are causing merging issues.

@GabrielCTroia
Copy link
Contributor

Yes of course @jude-san no worries! Ideally you can open a PR per issue but whatever feels easier for you! Let me know if you need help with anyhting

@jude-san jude-san closed this Oct 20, 2023
@jude-san jude-san deleted the rootreadme branch October 20, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants