Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding clearAll tests to MemoryMovexStore.spec.ts #54

Closed
wants to merge 1 commit into from

Conversation

rohitverma007
Copy link

@rohitverma007 rohitverma007 commented Oct 7, 2023

related to issue #46
last one fails..
expect(received).toEqual(expected) // deep equality

       - Expected  -  1
       + Received  + 14
   
       - Object {}
       + Object {
       +   "counter": Object {
       +     "counter:1": Object {
       +       "rid": "counter:1",
       +       "state": Array [
       +         Object {
       +           "count": 2,
       +         },
       +         "4ff62b6299694959981a28551da28e41",
       +       ],
       +       "subscribers": Object {},
       +     },
       +   },
       + }
   
         140 |     await store.create('counter:2', { count: 2 });
         141 |     await store.clearAll();
       > 142 |     expect(store.all()).toEqual({});
             |                         ^
         143 |   });
         144 | });
         145 |

@GabrielCTroia
Copy link
Contributor

Hmm thank you for you help @rohitverma007! You can go ahead and fix the issue in the MemoryStore if you'd like to!

Do you want me to open another issue for it?

@rohitverma007
Copy link
Author

Sounds good, will work on it @GabrielCTroia , don't need to create another issue.

@GabrielCTroia
Copy link
Contributor

Sounds good, will work on it @GabrielCTroia , don't need to create another issue.

I can do it, and assign you to it! Thank you

@GabrielCTroia
Copy link
Contributor

Sounds good, will work on it @GabrielCTroia , don't need to create another issue.

I can do it, and assign you to it! Thank you

Oh wait, nevermind, I thought you're asking me to! :) Ok, let me know if you have any questions or need my help! 🙏

@GabrielCTroia GabrielCTroia added good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest labels Oct 9, 2023
* Update libs/movex/src/lib/movex-store/MemoryMovexStore.spec.ts

* Update libs/movex/src/lib/movex-store/MemoryMovexStore.spec.ts

---------

Co-authored-by: codieai[bot] <146276760+codieai[bot]@users.noreply.github.com>
GabrielCTroia added a commit that referenced this pull request Nov 5, 2023
Duplicate of #54 with fixes - Adding clearAll tests to MemoryMovexStore.spec.ts
@GabrielCTroia
Copy link
Contributor

This is fixed in #188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants