Skip to content
This repository has been archived by the owner on Jan 18, 2019. It is now read-only.

French translations (work in progress) #19

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Conversation

greut
Copy link
Contributor

@greut greut commented Apr 13, 2017

This is a work in progress PR. Any feedbacks, comments, help are welcome.

@delapuente
Copy link
Contributor

I would separate this PR into two: one with the infrastructure for the new language, and other for the translations.

@greut
Copy link
Contributor Author

greut commented Apr 17, 2017

@delapuente what would you consider being the infrastructure? I could easily split it off.

@belen-albeza
Copy link
Contributor

Hi @greut thanks for your initiative in translating this to French. Merci beaucoup!

Please note the following:

  • Do not add a permalink / collection if that set has not been translated yet.
  • It'd be good if you could separate 1PR per document/guide translated. For instance, the setup guide (which consists of two markdown documents or "steps" would be a PR, the whole platform another one, etc.)
  • I'd rather avoid to have a translation of a guide that is not completed. For instance, it's OK if only the coaching guide is translated, but I'm reluctant to merge a guide that only some of the steps are in the target language (it could create false expectations in people).

Again, thanks a lot!

@greut greut changed the title Kick off the french translations. French translations (work in progress) Apr 21, 2017
@greut
Copy link
Contributor Author

greut commented Apr 21, 2017

@belen-albeza I'm currently building it as part of some teaching I'm doing. I'll split the work into more finelly grained PR for each guide then, once ready.

This PR make this translation effort visible, I've changed to title to reflect that.

De nada! I'm the one thanking you.

Signed-off-by: Yoan Blanc <[email protected]>
Signed-off-by: Yoan Blanc <[email protected]>
Signed-off-by: Yoan Blanc <[email protected]>
Signed-off-by: Yoan Blanc <[email protected]>
Signed-off-by: Yoan Blanc <[email protected]>
Signed-off-by: Yoan Blanc <[email protected]>
Signed-off-by: Yoan Blanc <[email protected]>
Signed-off-by: Yoan Blanc <[email protected]>
Signed-off-by: Yoan Blanc <[email protected]>
Signed-off-by: Yoan Blanc <[email protected]>
Signed-off-by: Yoan Blanc <[email protected]>
@belen-albeza
Copy link
Contributor

Please could you not change Phaser's version? 2.7.x corresponds to the community edition and I have not tested the code there. 2.6.2 is the latest one supported officially, and I believe it's more reliable to use that for the tutorial until Phaser 3 is released.

Thanks!

@greut
Copy link
Contributor Author

greut commented Apr 25, 2017

@belen-albeza duly noted. It seemed to fire less warnings and it's a commit that can be ditched as required.

greut added 3 commits May 2, 2017 14:48
Signed-off-by: Yoan Blanc <[email protected]>
Signed-off-by: Yoan Blanc <[email protected]>
(Basic though)

Signed-off-by: Yoan Blanc <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants