Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate consolidating/simplyfing code #248

Open
denschub opened this issue Nov 16, 2021 · 0 comments
Open

Investigate consolidating/simplyfing code #248

denschub opened this issue Nov 16, 2021 · 0 comments

Comments

@denschub
Copy link
Member

From a Chat with Tom on 2021-09-27:

i'm starting to think we should consolidate all of the code. there have been at least two cases where UA overrides needed a content script now anyway, so the code is starting to bleed together enough to consider it
we could just make everything be a type of shim, get rid of the others, and rename the shims "interventions"

There wasn't a tracking issue for that yet, so let's have this one. There are multiple ideas on how we could approach this, but one idea would be to completely remove the distinction between the current "types", and only have something like a setup() and shutdown() function for each intervention where we could do arbitrary stuff - helped by some functions for frequently used tasks.

Since there isn't too much code duplication for each intervention type at the moment, we have to be careful about not making things more complicated then they currently are... :) but it should be possible to have a couple of wins.

Let's use this issue to keep track of ideas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant