Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update moz.l10n, add hacky verbose resource diff #96

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

eemeli
Copy link
Member

@eemeli eemeli commented Nov 21, 2024

Added a developer utility --verbose option to .github/scripts/diff.py which isn't used in CI, but when used prints a very verbose diff of resources that differ. To do that, it's abusing pytest internals (not a dependency, needs to be installed separately).

The code is ugly enough that it didn't seem like a good idea to put it in moz.l10n.

Updating moz.l10n also revealed that prior to mozilla/moz-l10n#21, standalone .properties comments had been attached to the subsequent entry. Here, they're separated out again like they should be.

@bcolsson Merging this will also bring in mozilla/moz-l10n#26, which drops the NUMBER() from Fluent selectors. Therefore, it would probably be a good idea to pause sync while merging this, and to run l10n-fix here to apply the change to all files.

In firefox-l10n, translated messages can be migrated with something like this:

git grep -l 'NUMBER.*->' | xargs l10n-fix

Currently, that's resulting in 109 changed files when I run it.

@eemeli eemeli requested a review from a team as a code owner November 21, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant