Bugfix FXIOS-10696 Dismiss search bar when tap on the outside view in…

… HistoryPanel (#23276) * Added Cancel button to searchBar in HistoryPanel to close the keyboard
mozilla-mobile · Nov 26, 2024 · 65b7f9a · 65b7f9a
1 parent 72f84e4
commit 65b7f9a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/firefox-ios/Client/Frontend/Library/HistoryPanel/HistoryPanel+Search.swift b/firefox-ios/Client/Frontend/Library/HistoryPanel/HistoryPanel+Search.swift
@@ -27,6 +27,11 @@ extension HistoryPanel: UISearchBarDelegate {
         performSearch(term: searchText)
     }
 
+    func searchBarCancelButtonClicked(_ searchBar: UISearchBar) {
+        bottomStackView.isHidden = true
+        searchBar.resignFirstResponder()
+    }
+
     func startSearchState() {
         updatePanelState(newState: .history(state: .search))
         bottomStackView.isHidden = false

diff --git a/firefox-ios/Client/Frontend/Library/HistoryPanel/HistoryPanel.swift b/firefox-ios/Client/Frontend/Library/HistoryPanel/HistoryPanel.swift
@@ -97,6 +97,7 @@ class HistoryPanel: UIViewController,
         searchbar.searchTextField.placeholder = self.viewModel.searchHistoryPlaceholder
         searchbar.returnKeyType = .go
         searchbar.delegate = self
+        searchbar.showsCancelButton = true
     }
 
     private lazy var tableView: UITableView = .build { [weak self] tableView in
@@ -176,7 +177,6 @@ class HistoryPanel: UIViewController,
         setupLayout()
         configureDataSource()
         applyTheme()
-
         // Update theme of already existing view
         bottomStackView.applyTheme(theme: currentTheme())
     }