Refactor MTE-3854 WIP: Menu Refactor Cherry Pick (Smoke Test only) #23239
+11,727
−2,252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarmso
changed the title
Client.app: Coverage: 31.17
ComponentLibrary: Coverage: 30.88
MenuKit: Coverage: 40.29
libAccount.a: Coverage: 30.82
libStorage.a: Coverage: 55.7
Generated by 🚫 Danger Swift against 88273fd |
clarmso
commented
Nov 19, 2024
| @@ -111,6 +111,7 @@ | |||
| "HistoryHighlightsDataAdaptorTests\/testReloadDataOnNotification()", | |||
| "HistoryHighlightsTests", | |||
| "IntroViewControllerTests\/testBasicSetupReturnsExpectedItems()", | |||
| "PocketViewModelTests\/testClickingDiscoverCell_recordsTapOnStory()", | |||
There was a problem hiding this comment.
No idea why those unit tests fail in Bitrise. :(
clarmso
added
the
Do Not Merge ⛔️
clarmso
changed the title
6 tasks
isabelrios
reviewed
Nov 21, 2024
| @@ -392,7 +383,7 @@ class BookmarksTests: BaseTestCase { | |||
|
|
|||
| private func bookmarkPageAndTapEdit() { | |||
| bookmark() | |||
| app.buttons["Edit"].waitAndTap() | |||
| bookmark() | |||
There was a problem hiding this comment.
do we need to go to bookmark() twice?
There was a problem hiding this comment.
This private function is for testEditBookmark(), a full functional test. This test bookmarks a page first and then opens the Bookmark page. Let me take a look what's going on here.
There was a problem hiding this comment.
Yes, we need to call bookmark() twice. Before the menu refactor, there's an "Edit" button from the toast to access the bookmarks panel right away.
After the menu refactor, there's no such a button. The way to open the bookmarks panel is to open the browser tab menu ➡️ Save ➡️ Edit Bookmarks (was "Add Bookmarks"). The second bookmarks() call opens the bookmarks panel.
|
@clarmso how is this work going? I just leave a question, apart from that, when do you expect this could land? |
This PR can land when the menu refactor is enabled. The We will address the issue on full functional tests after this PR is landed so that the developers are not blocked. |
clarmso
commented
Nov 21, 2024
| @@ -119,6 +120,7 @@ | |||
| "ShortcutRouteTests\/testOpenLastBookmarkShortcutWithInvalidUrl()", | |||
| "TabManagerTests\/testDeleteSelectedTab()", | |||
| "TabManagerTests\/testPrivatePreference_togglePBMDeletesPrivate()", | |||
| "TabToolbarHelperTests\/testTelemetryForSiteMenu()", | |||
There was a problem hiding this comment.
We can disable these unit test temporarily.
clarmso
removed
the
Do Not Merge ⛔️
|
FYI: I have not tested the changes with Xcode 16 and iOS 18 yet. |
|
@clarmso Can you rebase with latest main to see the changes working on xcode 16? the experiment will be enabled within this PR so that the change and tests land at the same time as we did with toolbar .. |
[FXIOS-10335] Initial attempt at fixing a leak of WKWebView and also a blank homepage bug that regressed as a result.
…Feedback & Studies descriptions are not tappable (#23212) Fix failing Learn More navigation for Settings by repairing delegate chain on initialization.
Update the strings to remove comment referring to Android localization since it's not relevant Co-authored-by: Sophie Amin <[email protected]>
* Bugfix FXIOS-10600 Nimbus github action change checkout and .git owner * undo debug changes
* FXIOS-10605 Firefox iOS: Nimbus Flag for ToS * Removed ToS feature from FeatureDebugViewController
…ned when I try to open just one new tab (#23253) Make self weak in the button action handler and remove code that checks for existing buttons
…alendar alert (#23266) * chore: update l10n string concat logic * fix: lint again
…1121050227 (#23288) Auto update SPM with latest rust-component release 134.0.20241121050227 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…nnection error page only (#23268) * Add FXIOS-10609 [Native Error Page] Added flag to show no internet connection error page only * renamed variables and improved error handling * Added default strings for title and description
…otection-lists-ios` (#23199) * chore: change config to account for attachments * chore: update remote settings script to pull in attachments * chore: commit all changes in RemoteSettingsData * fix: move changed files from tmp dir * fix: adjust path for attachments * chore: manually run script * chore: update swift schema and fix failing tests * fix: linting issue Co-authored-by: Nishant Bhasin <[email protected]> * fix: linting issue Co-authored-by: Nishant Bhasin <[email protected]> * fix: linting issue Co-authored-by: Nishant Bhasin <[email protected]> * fix: another linting issue * fix: do not format json files --------- Co-authored-by: Nishant Bhasin <[email protected]>
…Manager (#23184) * Handle privacy window fo iPad multi windows * Remove iPad check in appWillResignActiveNotification
…on Only (#23275) * FXIOS-10606 Firefox iOS: ToS Card in Onboarding - UI Creation Only * Fixed a SwiftLint warning * Refactored some code Fixed the theme change issue * Removed notificationCenter from init * Updating the theme via Themeable instead of Notifiable * Refactored some code
…ns/islands in the menu. (#23308) FXIOS-10569 #23140 ⁃ [Menu Redesign] Fix the margin and Padding for the sections/islands in the menu.
* Refactor - auto update credential provider script * fix: pull fix from central --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Issam Mani <[email protected]>
* Rename LegacyTabDisplayManager to TopTabDisplayManager * swiftlint
…Messages (#23301) * This partially reverts a change to sharing to accommodate the Info Card Referral project to avoid appending website titles to any link shared from the app.
…Switcher (#23271) * Progress Made * Completed Ticket * Addressed comments * Update firefox-ios/Client.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved Co-authored-by: Issam Mani <[email protected]> --------- Co-authored-by: Issam Mani <[email protected]>
* Remove crash alert * Remove commented code
* Update Bitrise to use XCode 16.1 * Update npm vulnrability * Add verbose to the swift command * Try edge version * Trying one thing * Update error handling in script * Remove edge version * Run script twice * Update focus * Revert npm change * Test remove shard script * Fix unit tests * Update simulator target * Change simulator * Disable some tests * Compile and test Focus on Github Actions * Use macos-15 runner * Run Focus tests for supported iOS versions * Revert to old workflow name * Update workflow name * Run Firefox smoke tests on Github Actions * Could the device matter? * Disable some more tests * Update danger version * Update package * How about iPad mini * How about using Github Actions to run old iOS versions? * Remove the update address from the smoke test --------- Co-authored-by: Laurie Marceau <[email protected]> Co-authored-by: Clare So <[email protected]> Co-authored-by: mbarone <[email protected]>
#23256) chore: enable address edit by default on US and CA
…ing on button (#23312)
Updated Icons from Acorn repo Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Bug 1929832 - Mark dau-reporting ping as deprecated This also removes it from the baseline schedule and should stop it from being sent. It will be fully removed at a later point. * Bug 1929832 - Rename to `usage-reporting` ping and remove the info fields
…wser (#23311) * FXIOS-10568 Firefox iOS: Show Onboarding Links in Modal Browser * Refactored some code
Localize [v134] String import 2024-11-25 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Update README with latest tech stack of Xcode 16.1 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…23202) * Add wallpaper view to new homescreen and configure redux for wallpaper changes * Add wallpaper middleware tests * fix linter errors * Add scrolling follow up and orientation change logic * PR Feedback * Remove wallpaper object dependency from view and state * Remove trailing whitespace
clarmso
had a problem deploying
to
github-pages
GitHub Actions
Failure
|
Sorry folks. Rebase failed again. Let me cherry pick the smoke tests-related changes momentarily. 😢 |
|
This pull request has conflicts when rebasing. Could you fix it @clarmso? 🙏 |
|
Clean PR here: #23381 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)