Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FXIOS-10603 Telemetry for pull refresh easter egg (backport #23252) #23277

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 21, 2024

📜 Tickets

Jira ticket
Github issue

💡 Description

Add Telemetry for pull refresh easter egg and change pull refresh telemetry to event type.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

This is an automatic backport of pull request #23252 done by [Mergify](https://mergify.com).

* Add telemetry for pull refresh

* Added correct bugs and data review link to new telemetry

---------

Co-authored-by: Filippo <[email protected]>
(cherry picked from commit a47b61c)

# Conflicts:
#	firefox-ios/Client/Frontend/Browser/WebView/PullRefreshView.swift
@mergify mergify bot requested a review from a team as a code owner November 21, 2024 09:14
@mergify mergify bot requested review from thatswinnie and removed request for a team November 21, 2024 09:14
@mergify mergify bot added the conflicts label Nov 21, 2024
Copy link
Contributor Author

mergify bot commented Nov 21, 2024

Cherry-pick of a47b61c has failed:

On branch mergify/bp/release/v133/pr-23252
Your branch is up to date with 'origin/release/v133'.

You are currently cherry-picking commit a47b61cf8.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   firefox-ios/Client/Telemetry/TelemetryWrapper.swift
	modified:   firefox-ios/Client/metrics.yaml

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   firefox-ios/Client/Frontend/Browser/WebView/PullRefreshView.swift

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 32.65%
📖 Edited 2 files
📖 Created 1 files

Client.app: Coverage: 30.67

File Coverage
TelemetryWrapper.swift 71.47%

Generated by 🚫 Danger Swift against 4041a6d

@FilippoZazzeroni FilippoZazzeroni requested review from FilippoZazzeroni and removed request for thatswinnie November 21, 2024 09:25
@FilippoZazzeroni FilippoZazzeroni added the weekly-release Tagging backports for rapid release label Nov 21, 2024
@FilippoZazzeroni
Copy link
Collaborator

This should be merged in case PullRefresh gets merged Pull refresh PR

@FilippoZazzeroni
Copy link
Collaborator

Closing since this feature is going in 134

@DonalMe DonalMe deleted the mergify/bp/release/v133/pr-23252 branch December 5, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts weekly-release Tagging backports for rapid release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants