Bugfix FXIOS-10646 Ensure we do not change Menu > Share behaviour to Messages #23301
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rd Referral project to avoid appending website titles to any link shared from the app.
Client.app: Coverage: 31.31
Generated by 🚫 Danger Swift against f0c44f7 |
adudenamedruby
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
This PR partially reverts a change to sharing to accommodate the Info Card Referral project. This change avoids appending website titles to any link shared from the app (specifically to Messages for feature parity with Safari).
Demo
Before
Undesired behaviour when sharing a website URL from Menu > Share:
After
Desired behaviour when sharing a website URL from Menu > Share:
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)