Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix FXIOS-10560 - Password Generator: Keyboard Closing After Accessing Pass Gen #23305

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DanielDervishi
Copy link
Collaborator

@DanielDervishi DanielDervishi commented Nov 22, 2024

📜 Tickets

Jira ticket
Github issue

💡 Description

Added the ability to specify a dismiss completion handler for a bottom sheet. I don't really know how valuable this is for bottomsheets in general, so I could definitely just create a subclass of bottom sheet VC for password generator which overrides dismiss functionality. Some thoughts and feedback on this would be great.

This is also a sort of hacky way of fixing the bug which we may not want to move forward with. It leverages the seemingly auto focusing capabilities that come with reloading the webview for an accessory view in order to show the keyboard again for the password generator.

Also its worth noting that clicking onto another field would not switch to the standard keyboard view, even if its not a keyboard field due to the nature of when accessory views are loaded (pretty sure they have to explicitly be loaded) and I don't believe that the standard accessory view is loaded whenever we focus a non-special field.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant