Bugfix FXIOS-10560 - Password Generator: Keyboard Closing After Accessing Pass Gen #23305
+17
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Added the ability to specify a dismiss completion handler for a bottom sheet. I don't really know how valuable this is for bottomsheets in general, so I could definitely just create a subclass of bottom sheet VC for password generator which overrides dismiss functionality. Some thoughts and feedback on this would be great.
This is also a sort of hacky way of fixing the bug which we may not want to move forward with. It leverages the seemingly auto focusing capabilities that come with reloading the webview for an accessory view in order to show the keyboard again for the password generator.
Also its worth noting that clicking onto another field would not switch to the standard keyboard view, even if its not a keyboard field due to the nature of when accessory views are loaded (pretty sure they have to explicitly be loaded) and I don't believe that the standard accessory view is loaded whenever we focus a non-special field.
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120
)