Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added FXIOS-10710 default browser telemetry #23426

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Added FXIOS-10710 default browser telemetry #23426

wants to merge 14 commits into from
+410 −24

Conversation

OrlaM
Copy link
Contributor

@OrlaM OrlaM commented Nov 26, 2024 •
edited
Loading

📜 Tickets

Jira ticket
Github issue

💡 Description

Marking as do not merge for now as this cannot be merged until Apple release the RC of 18.2.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@OrlaM OrlaM added the Do Not Merge ⛔️ This issue is a work in progress and is not ready to land label Nov 26, 2024
@OrlaM OrlaM requested review from a team as code owners November 26, 2024 21:54
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 26, 2024

This pull request has conflicts when rebasing. Could you fix it @OrlaM? 🙏

@OrlaM OrlaM force-pushed the om/FXIOS-10710-default-browser-telemetry branch from 5b55f44 to da2f042 Compare November 26, 2024 21:55
@OrlaM OrlaM requested review from clarmso and Cramsden and removed request for isabelrios November 26, 2024 21:57
Cramsden
Cramsden approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@Cramsden Cramsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about test class name but looks good to me!

@OrlaM OrlaM force-pushed the om/FXIOS-10710-default-browser-telemetry branch from da2f042 to 8fe0f21 Compare November 28, 2024 14:47
@OrlaM OrlaM closed this Nov 28, 2024
@OrlaM OrlaM reopened this Nov 28, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 28, 2024

This pull request has conflicts when rebasing. Could you fix it @OrlaM? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cramsden Cramsden Cramsden approved these changes

@clarmso clarmso Awaiting requested review from clarmso

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Do Not Merge ⛔️ This issue is a work in progress and is not ready to land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OrlaM @Cramsden