Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FXIOS-10714 [Sponsored tiles] Create SponsoredTileNetworkUtility #23430

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

lmarceau
Copy link
Contributor

📜 Tickets

Jira ticket
Github issue

💡 Description

Adding the skeleton of the network and provider classes. The structure is based on the existing ContileProvider and ContileNetworking classes. Goal is to make something quick (and normally that will stay in the code base temporarily). Next PR will be to add the actual networking/parsing code with unit tests (just in case temporary becomes permanent :).

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@lmarceau lmarceau requested a review from a team as a code owner November 27, 2024 02:08
@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Nov 27, 2024

Messages
📖 Project coverage: 33.55%
📖 Edited 1 files
📖 Created 2 files

Client.app: Coverage: 31.64

File Coverage
UnifiedAdsNetwork.swift 0.0% ⚠️
UnifiedAdsProvider.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against 219cc03

@lmarceau lmarceau merged commit c66fda7 into main Nov 27, 2024
10 checks passed
@lmarceau lmarceau deleted the lm/FXIOS-10714-#23417-sponsoredTileNetworkUtility branch November 27, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants