Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FXIOS-10347 [ToS] Firefox iOS: Manage Privacy Preferences during Onboarding UI #23446

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add FXIOS-10347 [ToS] Firefox iOS: Manage Privacy Preferences during Onboarding UI #23446

wants to merge 6 commits into from

Conversation

dicarobinho
Copy link
Collaborator

📜 Tickets

Jira ticket

💡 Description

Created the UI for Mange Privacy Preferences screen

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@dicarobinho dicarobinho marked this pull request as ready for review November 28, 2024 10:00
@dicarobinho dicarobinho requested a review from a team as a code owner November 28, 2024 10:00
@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Nov 28, 2024 •
edited
Loading

Messages
📖 Project coverage: 33.04%
📖 Edited 5 files
📖 Created 2 files

Client.app: Coverage: 31.77

File Coverage
SwitchDetailedView.swift 0.0% ⚠️
TermsOfServiceViewController.swift 81.82% ✅
PrivacyPreferencesViewController.swift 0.0% ⚠️

ComponentLibrary: Coverage: 31.57

File Coverage
HeaderView.swift 33.56% ⚠️

Generated by 🚫 Danger Swift against d4281b2

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 28, 2024

This pull request has conflicts when rebasing. Could you fix it @dicarobinho? 🙏

@dicarobinho
Merge branch 'main' into afarcasanu/fxios_10347_manage_privacy_prefer…
d4281b2 
…ences_during_onboarding_ui

# Conflicts:
#	firefox-ios/Client.xcodeproj/project.pbxproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatswinnie thatswinnie Awaiting requested review from thatswinnie

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dicarobinho @mobiletest-ci-bot