Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FXIOS-10638 [ToS] Firefox iOS: Use the correct Terms of Service and Privacy Notice URLs in ToSViewController #23450

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Add FXIOS-10638 [ToS] Firefox iOS: Use the correct Terms of Service and Privacy Notice URLs in ToSViewController #23450

merged 1 commit into from
Nov 29, 2024

Conversation

dicarobinho
Copy link
Collaborator

📜 Tickets

Jira ticket

💡 Description

Added the links for Privacy Notice and Terms of Service

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@dicarobinho dicarobinho marked this pull request as ready for review November 28, 2024 13:22
@dicarobinho dicarobinho requested a review from a team as a code owner November 28, 2024 13:22
@dicarobinho dicarobinho requested review from FilippoZazzeroni and thatswinnie and removed request for FilippoZazzeroni November 28, 2024 13:22
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 32.86%
📖 Edited 1 files
📖 Created 0 files

Client.app: Coverage: 31.81

File Coverage
TermsOfServiceViewController.swift 84.11% ✅

Generated by 🚫 Danger Swift against 6e277c3

@dicarobinho dicarobinho merged commit 3f1f216 into main Nov 29, 2024
10 checks passed
@dicarobinho dicarobinho deleted the afarcasanu/fxios_10638_use_the_correct_terms_of_service_and_privacy_notice_urls branch November 29, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatswinnie thatswinnie thatswinnie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dicarobinho @mobiletest-ci-bot @thatswinnie