Add FXIOS-10715 [sponsored tiles] Get unified ads data with a POST request #23455
Conversation
lmarceau
requested review from
mdotb-moz and
adudenamedruby
and removed request for
mdotb-moz
| 8A3345612BA499B7008C52AB /* disconnect-block-fingerprinting.json in Resources */ = {isa = PBXBuildFile; fileRef = 8A3345572BA499B6008C52AB /* disconnect-block-fingerprinting.json */; }; | ||
| 8A3345622BA499B7008C52AB /* disconnect-block-advertising.json in Resources */ = {isa = PBXBuildFile; fileRef = 8A3345582BA499B6008C52AB /* disconnect-block-advertising.json */; }; | ||
| 8A3345632BA499B7008C52AB /* disconnect-block-cookies-content.json in Resources */ = {isa = PBXBuildFile; fileRef = 8A3345592BA499B6008C52AB /* disconnect-block-cookies-content.json */; }; | ||
| 8A3345642BA499B7008C52AB /* disconnect-block-analytics.json in Resources */ = {isa = PBXBuildFile; fileRef = 8A33455A2BA499B6008C52AB /* disconnect-block-analytics.json */; }; | ||
| 8A3345652BA499B7008C52AB /* disconnect-block-cookies-advertising.json in Resources */ = {isa = PBXBuildFile; fileRef = 8A33455B2BA499B7008C52AB /* disconnect-block-cookies-advertising.json */; }; | ||
| 8A3345662BA499B7008C52AB /* disconnect-block-content.json in Resources */ = {isa = PBXBuildFile; fileRef = 8A33455C2BA499B7008C52AB /* disconnect-block-content.json */; }; | ||
| 8A3345672BA499B7008C52AB /* disconnect-block-cookies-analytics.json in Resources */ = {isa = PBXBuildFile; fileRef = 8A33455D2BA499B7008C52AB /* disconnect-block-cookies-analytics.json */; }; | ||
| 8A3345682BA499B7008C52AB /* disconnect-block-social.json in Resources */ = {isa = PBXBuildFile; fileRef = 8A33455E2BA499B7008C52AB /* disconnect-block-social.json */; }; | ||
| 8A3345692BA499B7008C52AB /* disconnect-block-cookies-social.json in Resources */ = {isa = PBXBuildFile; fileRef = 8A33455F2BA499B7008C52AB /* disconnect-block-cookies-social.json */; }; | ||
| 8A33456A2BA499B7008C52AB /* disconnect-block-cryptomining.json in Resources */ = {isa = PBXBuildFile; fileRef = 8A3345602BA499B7008C52AB /* disconnect-block-cryptomining.json */; }; |
There was a problem hiding this comment.
I'll revert this, but I am not sure why this appears here.
There was a problem hiding this comment.
@OrlaM is this the UnifiedAds work we were saying would be a good candidate to live in AS?
| private static let prodResourceEndpoint = "https://ads.mozilla.org/v1/ads" | ||
| static let stagingResourceEndpoint = "https://ads.allizom.org/v1/ads" |
There was a problem hiding this comment.
are we sure we want the ads urls public? Has this been discussed?
There was a problem hiding this comment.
Mhh, so this one is public as the one is public in ContileProvider. It's public to be accessed by the unit tests. It's not a good reasons to make it public, so happy to change this. I guess I could duplicate it for unit tests if it's not public?
There was a problem hiding this comment.
Just asking that we're ok with that. For wallpapers, for example, it was explicitly not made public, so I'm just checking.
Yes it is. This work is to implement a short term solution in the meantime so we remain revenue compliant |
|
amazing! tyvm for providing more context!!! 👍 |
Client.app: Coverage: 31.87
Generated by 🚫 Danger Swift against 2e3a01f |
📜 Tickets
Jira ticket
Github issue
💡 Description
UnifiedAdsProviderto build a request either on the prod or staging endpoint. I kept the same caching mechanism as withContileProvider, so tiles will be cached for an hour.UnifiedAdsNetworksince turns out I can useContileNetworkingto make the url session request.📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)