Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix FXIOS-10437 [Menu] Attempt fix for menu coordinator bug #23458

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Bugfix FXIOS-10437 [Menu] Attempt fix for menu coordinator bug #23458

merged 2 commits into from
Nov 29, 2024
+28 −8

Conversation

adudenamedruby
Copy link
Contributor

@adudenamedruby adudenamedruby commented Nov 28, 2024 •
edited
Loading

📜 Tickets

Jira ticket
Github issue

💡 Description

IN the strange case that a coordinator exists, we dismiss relevant modals and remove the coordinator, and then re-add it properly, to ensure that the correct window UUID is being passed in. Logs have been added to help diagnose if it's not actually the correct window UUID.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@adudenamedruby adudenamedruby requested a review from a team as a code owner November 28, 2024 19:43
FilippoZazzeroni
FilippoZazzeroni approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@FilippoZazzeroni FilippoZazzeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @adudenamedruby 💪

@adudenamedruby
Copy link
Contributor Author

@Mergifyio backport release/v133

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 29, 2024 •
edited
Loading

backport release/v133

✅ Backports have been created

@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 33.94%
📖 Edited 3 files
📖 Created 0 files

Client.app: Coverage: 31.9

File Coverage
BrowserCoordinator.swift 68.72% ✅
MainMenuCoordinator.swift 88.24% ✅
MainMenuViewController.swift 22.43% ⚠️

Generated by 🚫 Danger Swift against 332157c

@adudenamedruby adudenamedruby merged commit b421b9a into main Nov 29, 2024
10 checks passed
@adudenamedruby adudenamedruby deleted the rgb/menuCoordinatorPossibleFix branch November 29, 2024 14:56
mergify bot pushed a commit that referenced this pull request Nov 29, 2024
@adudenamedruby @mergify
Bugfix FXIOS-10437 [Menu] Attempt fix for menu coordinator bug (#23458)
bba8c89 
* Attempt fix

* swifliiiiiint

(cherry picked from commit b421b9a)
@mergify mergify bot mentioned this pull request Nov 29, 2024
Open
6 tasks
@DonalMe
Copy link
Contributor

DonalMe commented Nov 29, 2024

@adudenamedruby this is missing a backport for 134?
It just landed in main, so this might not make the first 133 dot release. We could take it for the second planned dot release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FilippoZazzeroni FilippoZazzeroni FilippoZazzeroni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adudenamedruby @mobiletest-ci-bot @DonalMe @FilippoZazzeroni