Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FXIOS-10716 [sponsored tiles] Add telemetry class for unified ads #23463

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

lmarceau
Copy link
Contributor

📜 Tickets

Jira ticket
Github issue

💡 Description

Previous telemetry for click and impression on Sponsored tiles was sent through Glean (with the SponsoredTileTelemetry class). With the new unified ads API we need to make a GET request on the callback URLs provided when we request the tiles instead of relying on Glean.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@lmarceau lmarceau requested a review from a team as a code owner November 28, 2024 22:31
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 33.99%
📖 Edited 1 files
📖 Created 2 files

Client.app: Coverage: 31.89

File Coverage
UnifiedAdsCallbackTelemetry.swift 89.13%

Generated by 🚫 Danger Swift against 67ffeb3

@lmarceau lmarceau merged commit 465aee8 into main Nov 29, 2024
10 checks passed
@lmarceau lmarceau deleted the lm/FXIOS-10716-#23419-add-telemetry-callbacks branch November 29, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants