Fix max pixel scroll float issue that prevents some data from hitting…

… table (#102) * uses Math.trunc on maxPixelScrollDepth * adds comment * updates version number
mozilla-rally · Apr 22, 2021 · c066eee · c066eee
1 parent 89a1116
commit c066eee
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 6 deletions.
diff --git a/manifest.json b/manifest.json
@@ -3,7 +3,7 @@
   "author": "Mozilla Rally",
   "manifest_version": 2,
   "name": "Your Time Online and \"Doomscrolling\"",
-  "version": "0.1.4",
+  "version": "0.1.5",
   "homepage_url": "https://github.com/mozilla-rally/rally-study-01",
 
   "icons": {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "rally-study-01",
-  "version": "0.1.4",
+  "version": "0.1.5",
   "scripts": {
     "build": "npm run build:schema && rollup -c",
     "build:addon": "rollup -c && web-ext build --overwrite-dest",

diff --git a/src/content-scripts/attention-collector.js b/src/content-scripts/attention-collector.js
@@ -301,10 +301,15 @@
 
                     scrollHeight = document.documentElement.scrollHeight;
 
+                    // We accidentally let the schema type for this be `integer` so 
+                    // we will have to truncate, since on occasion this reports a float.
                     maxPixelScrollDepth =
-                        Math.min(scrollHeight,
-                            Math.max(maxPixelScrollDepth, window.scrollY + document.documentElement.clientHeight)
-                        );
+                        Math.trunc(
+                            Math.min(scrollHeight,
+                                Math.max(maxPixelScrollDepth, window.scrollY + document.documentElement.clientHeight)
+                        )
+                    );
+
                     maxRelativeScrollDepth = Math.min(
                         Math.max(maxRelativeScrollDepth, (window.scrollY + document.documentElement.clientHeight) / scrollHeight),
                         1);