Add support for soft/hard block in upload_to_mllf_to_remote_settings cron #22885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinMind
changed the base branch from
soft-block-bloom-filter-filter
to
master
KevinMind
changed the title
KevinMind
force-pushed
the
soft-block-cron-job
branch
2 times, most recently
from
6884583
to
32b86be
Compare
KevinMind
force-pushed
the
soft-block-cron-job
branch
from
32b86be
to
7ad8894
Compare
5 tasks
willdurand
reviewed
Nov 25, 2024
KevinMind
force-pushed
the
soft-block-cron-job
branch
from
7ad8894
to
118357c
Compare
KevinMind
force-pushed
the
soft-block-upload-task
branch
2 times, most recently
from
2488f60
to
9efc622
Compare
KevinMind
force-pushed
the
soft-block-cron-job
branch
from
118357c
to
7ce011d
Compare
KevinMind
force-pushed
the
soft-block-upload-task
branch
from
9efc622
to
256e667
Compare
KevinMind
force-pushed
the
soft-block-cron-job
branch
from
7ce011d
to
c182794
Compare
KevinMind
force-pushed
the
soft-block-cron-job
branch
2 times, most recently
from
4b1719c
to
d8a5812
Compare
…cron: - adds support to process fort blocks in the cron - does not actually support soft blocks, we skip them always - adds test proving we always skip them This commit makes actually adding them more clear and easier to grok
KevinMind
force-pushed
the
soft-block-cron-job
branch
from
c7b11c2
to
3032f48
Compare
willdurand
requested changes
Nov 25, 2024
Co-authored-by: William Durand <[email protected]> Update src/olympia/blocklist/cron.py Co-authored-by: William Durand <[email protected]> Update src/olympia/blocklist/cron.py Co-authored-by: William Durand <[email protected]> Update src/olympia/blocklist/cron.py Co-authored-by: William Durand <[email protected]> Update src/olympia/blocklist/cron.py Co-authored-by: William Durand <[email protected]> Update src/olympia/blocklist/cron.py Co-authored-by: William Durand <[email protected]> Update src/olympia/blocklist/tests/test_cron.py Co-authored-by: William Durand <[email protected]>
KevinMind
force-pushed
the
soft-block-cron-job
branch
from
ef1cd49
to
29949e2
Compare
KevinMind
force-pushed
the
soft-block-cron-job
branch
from
8c7f026
to
ac83d58
Compare
willdurand
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: mozilla/addons#15014
Description
Context
This commit makes actually adding them more clear and easier to grok
Testing
Test exactly the same as #22828
Adding hard or soft blocks should produce only hard block filter/stash regardless of the soft block change count or the
enable-soft-blockingwaffle_switch.Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.