-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add forward to legal option in reviewer tools #22886
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, mostly regarding the tests. It looks pretty good so far. I think some parts need more explanation to ensure this continues making sense in the future. I'll verify the behavior and approve.
63b4338
to
03d282f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After much testing, the patch is verified. 🚢 🫡
Store override decisions as seperate ContentDecision instances
* Store override decisions as seperate ContentDecision instances * Add forward to legal option in reviewer tools * review follow-ups * add integration test * other random requested changes * more changes * test fix * test fix post merge
Fixes: mozilla/addons#15078
Description
Adds a Request legal action in the reviewer tools. Under the hood the activity log is attached to
DECISION_ACTIONS.AMO_LEGAL_FORWARD
, which has an associated ContentAction class with a process action that resolves the job (if there was one); then creates a new job in the legal escalations queue.Context
There's some TODOs that will be resolved with future refactoring, as it's the first reviewer-tools-launched-action where the
process_action
in the ContentActionXXX needs to do something. (currently all the actions from the reviewer tools do the necessary action in reviewers/utils.py first)Testing
Checklist
#ISSUENUM
at the top of your PR to an existing open issue in the mozilla/addons repository.