-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh: use Firefox brand fonts on some Firefox pages [fix #15542] #15569
Conversation
There are also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A deceptively easy solution!
I think we should merge #15571 and then rebase this to use the same switches that look for locale activation.
Oh good catch, I'll update these as well. |
bc953ee
to
ddd749f
Compare
Nightly WNP: http://localhost:8000/firefox/135.0a1/whatsnew/ |
To complete the list to test, there's also the non-MDN FXDE WNP (=for older versions): http://localhost:8000/firefox/99.0a2/whatsnew/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working great. The nothing personal page is missing the site_css
block. I added it locally and it works fine to once it's added here it's good to merge.
R+ wc
ddd749f
to
a3b67d1
Compare
whatsnew, welcome, and campaign pages
a3b67d1
to
65d28a4
Compare
One-line summary
Keeps Firefox branding on whatsnew, welcome, and campaign pages (mainly for the fonts).
This is admittedly a bit hacky and loads extra fonts so it's a performance hit, but doing it "properly" would probably entail a more significant refactoring of the nav and footer as well as some global styles. We should tackle that at another time.
Issue / Bugzilla link
#15542
Testing
Test a handful of whatsnew and welcome pages with the M24_WEBSITE_REFRESH switch on; make sure the text is rendered in Metropolis and Inter. The footer should use the new Mozilla fonts (only English gets the new footer; other languages get the old footer for now).
http://localhost:8000/firefox/125.0/whatsnew/
http://localhost:8000/firefox/132.0/whatsnew/
http://localhost:8000/firefox/133.0/whatsnew/
http://localhost:8000/firefox/welcome/1/
http://localhost:8000/firefox/welcome/10/
Firefox for Families page; make sure the page body has Metropolis and Inter, and the nav and footer render in Mozilla fonts (and don't otherwise break).
http://localhost:8000/firefox/family/
Nothing Personal page should use Firefox fonts and Mozilla fonts in the footer (this page has no nav):
http://localhost:8000/firefox/nothing-personal/
Challenge the Default page should use Firefox fonts, but this is an odd one because currently it's not available in English but the new Mozilla fonts are English-only. That logic will change soon so this is a pre-emptive strike.
http://localhost:8000/firefox/challenge-the-default/