Fix missing for-developers ftl fallback #15583
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbrasna
commented
Nov 27, 2024
| @@ -13,7 +13,7 @@ | |||
| ) %} | |||
| <h2 class="mzp-u-title-xs">{{ ftl('firefox-developer-firefox-developer-edition') }}</h2> | |||
| <h3 class="mzp-u-title-sm">{{ ftl('firefox-developer-made-for-developers') }}</h3> | |||
| <p>{{ ftl('firefox-developer-all-the-latest-v2', fallback='firefox-developer-all-the-latest') }}</p> | |||
| <p>{{ ftl('firefox-developer-all-the-latest-v2') }}</p> | |||
There was a problem hiding this comment.
In theory they still exist in a few locales: @mozilla-l10n/www-l10n: "firefox-developer-all-the-latest" but:
da&thalready have the new string anywaysbeis the only one not having the new string — so this one will default to en, but better than refer to (outdated) experimental features etc. — but if it's gone from en, it's gone…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Removes nonexistent fallback string id.
Significant changes and points to review
Obsolete string got removed in
d08bd22— but left in the template.Issue / Bugzilla link
🚫🐞
Testing
/en-US/firefox/developer/